Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HCB Phone Number #1101

Merged
merged 6 commits into from Mar 14, 2024
Merged

Add HCB Phone Number #1101

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee0f16b
Updated the Phone Number
Chay2203 Mar 7, 2024
17dd77f
Updated the Phone Number in HCB related Pages
Chay2203 Mar 7, 2024
89ebf8e
Updated phone number with hyphen
Chay2203 Mar 7, 2024
c9d5c50
Updated the variable name
Chay2203 Mar 14, 2024
68ed8fd
Remove parentheses from phone number URI
garyhtou Mar 14, 2024
da54a25
Merge branch 'main' into phone-number
garyhtou Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/footer.js
View file
Open in desktop
Expand Up @@ -179,7 +179,7 @@ const Footer = ({
<Service href={`mailto:${email}`} icon="email-fill" />
</Grid>
<Text my={2}>
<Link href="tel:1-855-625-HACK">1-855-625-HACK</Link>
<Link href="tel:+1 (844) 237 2290">+1 (844) 237 2290</Link>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! In addition to @sampoder's feedback, can we also change the phone number in the href to use hyphens as the separator?

This is because the spec says tel URIs should not contain spaces.

The inner content of the link can stay the same!

Suggested change
<Link href="tel:+1 (844) 237 2290">+1 (844) 237 2290</Link>
<Link href="tel:+1-844-237-2290">+1 (844) 237 2290</Link>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @garyhtou

<br />
<Text as="span" color="muted">
(call toll-free)
Expand Down