New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azurerm_eventgrid_* resources #5948
Closed
jrauschenbusch
wants to merge
7
commits into
hashicorp:master
from
jrauschenbusch:eventgrid-resources
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f305c0b
Update: r/eventgrid_*
jrauschenbusch a9f12ae
fixing tflint and lintrest violations
jrauschenbusch 65259c9
Refactoring of azurerm_eventgrid_event_subscription resource
jrauschenbusch 74a64a1
fix: review notes
jrauschenbusch 1478ff1
fix: adapt to nested variable structure
jrauschenbusch 4966c78
fix: depscheck
jrauschenbusch 13213ee
fix: lintrest
jrauschenbusch File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
156 changes: 156 additions & 0 deletions
156
azurerm/internal/services/eventgrid/resource_arm_eventgrid_domain_topic.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,156 @@ | ||
| package eventgrid | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "log" | ||
| "time" | ||
|
|
||
| "github.com/hashicorp/go-azure-helpers/response" | ||
| "github.com/hashicorp/terraform-plugin-sdk/helper/schema" | ||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure" | ||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/tf" | ||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/clients" | ||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/features" | ||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/timeouts" | ||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils" | ||
| ) | ||
|
|
||
| func resourceArmEventGridDomainTopic() *schema.Resource { | ||
| return &schema.Resource{ | ||
| Create: resourceArmEventGridDomainTopicCreateUpdate, | ||
| Read: resourceArmEventGridDomainTopicRead, | ||
| Update: resourceArmEventGridDomainTopicCreateUpdate, | ||
| Delete: resourceArmEventGridDomainTopicDelete, | ||
| Importer: &schema.ResourceImporter{ | ||
| State: schema.ImportStatePassthrough, | ||
| }, | ||
|
|
||
| Timeouts: &schema.ResourceTimeout{ | ||
| Create: schema.DefaultTimeout(30 * time.Minute), | ||
| Read: schema.DefaultTimeout(5 * time.Minute), | ||
| Update: schema.DefaultTimeout(30 * time.Minute), | ||
| Delete: schema.DefaultTimeout(30 * time.Minute), | ||
| }, | ||
|
|
||
| Schema: map[string]*schema.Schema{ | ||
| "name": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| ForceNew: true, | ||
| }, | ||
|
|
||
| "domain_name": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| }, | ||
|
|
||
| "resource_group_name": azure.SchemaResourceGroupName(), | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| func resourceArmEventGridDomainTopicCreateUpdate(d *schema.ResourceData, meta interface{}) error { | ||
| client := meta.(*clients.Client).EventGrid.DomainTopicsClient | ||
| ctx, cancel := timeouts.ForCreateUpdate(meta.(*clients.Client).StopContext, d) | ||
| defer cancel() | ||
|
|
||
| name := d.Get("name").(string) | ||
| domainName := d.Get("domain_name").(string) | ||
| resourceGroup := d.Get("resource_group_name").(string) | ||
|
|
||
| if features.ShouldResourcesBeImported() && d.IsNewResource() { | ||
| existing, err := client.Get(ctx, resourceGroup, domainName, name) | ||
| if err != nil { | ||
| if !utils.ResponseWasNotFound(existing.Response) { | ||
| return fmt.Errorf("Error checking for presence of existing EventGrid Domain Topic %q (Resource Group %q): %s", name, resourceGroup, err) | ||
| } | ||
| } | ||
|
|
||
| if existing.ID != nil && *existing.ID != "" { | ||
| return tf.ImportAsExistsError("azurerm_eventgrid_domain_topic", *existing.ID) | ||
| } | ||
| } | ||
|
|
||
| future, err := client.CreateOrUpdate(ctx, resourceGroup, domainName, name) | ||
| if err != nil { | ||
| return fmt.Errorf("Error creating/updating EventGrid Domain Topic %q (Resource Group %q): %s", name, resourceGroup, err) | ||
| } | ||
|
|
||
| if err = future.WaitForCompletionRef(ctx, client.Client); err != nil { | ||
| return fmt.Errorf("Error waiting for EventGrid Domain Topic %q (Resource Group %q) to become available: %s", name, resourceGroup, err) | ||
| } | ||
|
|
||
| read, err := client.Get(ctx, resourceGroup, domainName, name) | ||
| if err != nil { | ||
| return fmt.Errorf("Error retrieving EventGrid Domain Topic %q (Resource Group %q): %s", name, resourceGroup, err) | ||
| } | ||
| if read.ID == nil { | ||
| return fmt.Errorf("Cannot read EventGrid Domain Topic %q (resource group %s) ID", name, resourceGroup) | ||
| } | ||
|
|
||
| d.SetId(*read.ID) | ||
|
|
||
| return resourceArmEventGridDomainTopicRead(d, meta) | ||
| } | ||
|
|
||
| func resourceArmEventGridDomainTopicRead(d *schema.ResourceData, meta interface{}) error { | ||
| client := meta.(*clients.Client).EventGrid.DomainTopicsClient | ||
| ctx, cancel := timeouts.ForRead(meta.(*clients.Client).StopContext, d) | ||
| defer cancel() | ||
|
|
||
| id, err := azure.ParseAzureResourceID(d.Id()) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| resourceGroup := id.ResourceGroup | ||
| domainName := id.Path["domains"] | ||
| name := id.Path["topics"] | ||
|
|
||
| resp, err := client.Get(ctx, resourceGroup, domainName, name) | ||
| if err != nil { | ||
| if utils.ResponseWasNotFound(resp.Response) { | ||
| log.Printf("[WARN] EventGrid Domain Topic %q was not found (Resource Group %q)", name, resourceGroup) | ||
| d.SetId("") | ||
| return nil | ||
| } | ||
|
|
||
| return fmt.Errorf("Error making Read request on EventGrid Domain Topic %q: %+v", name, err) | ||
| } | ||
|
|
||
| d.Set("name", resp.Name) | ||
| d.Set("domain_name", domainName) | ||
| d.Set("resource_group_name", resourceGroup) | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func resourceArmEventGridDomainTopicDelete(d *schema.ResourceData, meta interface{}) error { | ||
| client := meta.(*clients.Client).EventGrid.DomainTopicsClient | ||
| ctx, cancel := timeouts.ForDelete(meta.(*clients.Client).StopContext, d) | ||
| defer cancel() | ||
|
|
||
| id, err := azure.ParseAzureResourceID(d.Id()) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| resGroup := id.ResourceGroup | ||
| domainName := id.Path["domains"] | ||
| name := id.Path["topics"] | ||
|
|
||
| future, err := client.Delete(ctx, resGroup, domainName, name) | ||
| if err != nil { | ||
| if response.WasNotFound(future.Response()) { | ||
| return nil | ||
| } | ||
| return fmt.Errorf("Error deleting Event Grid Domain Topic %q: %+v", name, err) | ||
| } | ||
|
|
||
| if err = future.WaitForCompletionRef(ctx, client.Client); err != nil { | ||
| if response.WasNotFound(future.Response()) { | ||
| return nil | ||
| } | ||
| return fmt.Errorf("Error deleting Event Grid Domain Topic %q: %+v", name, err) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we write a specific parse function & use it like can be seen in #5356