Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project_id validated in datasource #12846

Merged
merged 1 commit into from Oct 20, 2022
Merged

project_id validated in datasource #12846

merged 1 commit into from Oct 20, 2022

Conversation

modular-magician
Copy link
Collaborator

project_id validated for datasource and required test added
fixes #5687

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudplatform: Validated `project_id` for `google_project` data-source

Derived from GoogleCloudPlatform/magic-modules#6691

@modular-magician
project_id validated in datasource (hashicorp#6691)
adbfa7a 
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit e4e1fc6 into hashicorp:main Oct 20, 2022
brian-fogg-candid-health pushed a commit to candidhealth/terraform-provider-google that referenced this pull request Oct 21, 2022
@modular-magician @brian-fogg-candid-health
project_id validated in datasource (hashicorp#6691) (hashicorp#12846)
eb18772 
Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
brian-fogg-candid-health pushed a commit to candidhealth/terraform-provider-google that referenced this pull request Oct 24, 2022
@modular-magician @brian-fogg-candid-health
project_id validated in datasource (hashicorp#6691) (hashicorp#12846)
d952486 
Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
@SarahFrench SarahFrench mentioned this pull request Oct 31, 2022
Closed
@msampathkumar msampathkumar mentioned this pull request Nov 1, 2022
Merged
bharathkkb pushed a commit to terraform-google-modules/terraform-docs-samples that referenced this pull request Nov 1, 2022
@msampathkumar
Update project names as hashicorp/terraform-provider-google#12846 (#215)
11b94f1 
Check b/256705397 for more details
afiune added a commit to lacework/terraform-gcp-config that referenced this pull request Nov 14, 2022
@afiune
fix: empty project_id in google_project data source
f1a584d 
A validation change hashicorp/terraform-provider-google#12846
was introduced in version `4.42.0` of the google provider. This
validation makes all our GCP modules to fail with:
```
│ Error: "" project_id must be 6 to 30 with lowercase letters, digits, hyphens and start with a letter. Trailing hyphens are prohibited.
│
│   with module.gcp_project_config.data.google_project.selected,
│   on .terraform/modules/gcp_project_config/main.tf line 96, in data "google_project" "selected":
│   96:   project_id = var.project_id
```

To solve this issue we are avoiding using the `google_project` data
source when we know the `project_id` that was provided by the user.

If the user does not provide a `project_id`, then we use the data
source to discover the project from the google provider.

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
@afiune afiune mentioned this pull request Nov 14, 2022
Merged
afiune added a commit to lacework/terraform-gcp-audit-log that referenced this pull request Nov 14, 2022
@afiune
fix: empty project_id in google_project data source
f01973c 
A validation change hashicorp/terraform-provider-google#12846
was introduced in version `4.42.0` of the google provider. This
validation makes all our GCP modules to fail with:
```
│ Error: "" project_id must be 6 to 30 with lowercase letters, digits, hyphens and start with a letter. Trailing hyphens are prohibited.
│
│   with module.gcp_project_audit_log.data.google_project.selected,
│   on .terraform/modules/gcp_project_audit_log/main.tf line 96, in data "google_project" "selected":
│   96:   project_id = var.project_id
```

To solve this issue we are avoiding using the `google_project` data
source when we know the `project_id` that was provided by the user.

If the user does not provide a `project_id`, then we use the data
source to discover the project from the google provider.

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
@afiune afiune mentioned this pull request Nov 14, 2022
Merged
afiune added a commit to lacework/terraform-gcp-gke-audit-log that referenced this pull request Nov 14, 2022
@afiune
fix: empty project_id in google_project data source
30c8262 
A validation change hashicorp/terraform-provider-google#12846
was introduced in version `4.42.0` of the google provider. This
validation makes all our GCP modules to fail with:
```
│ Error: "" project_id must be 6 to 30 with lowercase letters, digits, hyphens and start with a letter. Trailing hyphens are prohibited.
│
│   with module.gcp_project_gke_audit_log.data.google_project.selected,
│   on .terraform/modules/gcp_project_gke_audit_log/main.tf line 96, in data "google_project" "selected":
│   96:   project_id = var.project_id
```

To solve this issue we are avoiding using the `google_project` data
source when we know the `project_id` that was provided by the user.

If the user does not provide a `project_id`, then we use the data
source to discover the project from the google provider.

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
@afiune afiune mentioned this pull request Nov 14, 2022
Merged
afiune added a commit to lacework/terraform-gcp-service-account that referenced this pull request Nov 15, 2022
@afiune
fix: empty project_id in google_project data source
58b7de5 
A validation change hashicorp/terraform-provider-google#12846
was introduced in version `4.42.0` of the google provider. This
validation makes all our GCP modules to fail with:
```
│ Error: "" project_id must be 6 to 30 with lowercase letters, digits, hyphens and start with a letter. Trailing hyphens are prohibited.
│
│   with module.gcp_service_account.data.google_project.selected,
│   on .terraform/modules/gcp_service_account/main.tf line 96, in data "google_project" "selected":
│   96:   project_id = var.project_id
```

To solve this issue we are avoiding using the `google_project` data
source when we know the `project_id` that was provided by the user.

If the user does not provide a `project_id`, then we use the data
source to discover the project from the google provider.

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
@afiune afiune mentioned this pull request Nov 15, 2022
Merged
afiune added a commit to lacework/terraform-gcp-gke-audit-log that referenced this pull request Nov 15, 2022
@afiune
fix: empty project_id in google_project data source (#8)
e49c511 
A validation change hashicorp/terraform-provider-google#12846
was introduced in version `4.42.0` of the google provider. This
validation makes all our GCP modules to fail with:
```
│ Error: "" project_id must be 6 to 30 with lowercase letters, digits, hyphens and start with a letter. Trailing hyphens are prohibited.
│
│   with module.gcp_project_gke_audit_log.data.google_project.selected,
│   on .terraform/modules/gcp_project_gke_audit_log/main.tf line 96, in data "google_project" "selected":
│   96:   project_id = var.project_id
```

To solve this issue we are avoiding using the `google_project` data
source when we know the `project_id` that was provided by the user.

If the user does not provide a `project_id`, then we use the data
source to discover the project from the google provider.

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune added a commit to lacework/terraform-gcp-audit-log that referenced this pull request Nov 15, 2022
@afiune
fix: empty project_id in google_project data source (#77)
92261b8 
A validation change hashicorp/terraform-provider-google#12846
was introduced in version `4.42.0` of the google provider. This
validation makes all our GCP modules to fail with:
```
│ Error: "" project_id must be 6 to 30 with lowercase letters, digits, hyphens and start with a letter. Trailing hyphens are prohibited.
│
│   with module.gcp_project_audit_log.data.google_project.selected,
│   on .terraform/modules/gcp_project_audit_log/main.tf line 96, in data "google_project" "selected":
│   96:   project_id = var.project_id
```

To solve this issue we are avoiding using the `google_project` data
source when we know the `project_id` that was provided by the user.

If the user does not provide a `project_id`, then we use the data
source to discover the project from the google provider.

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune added a commit to lacework/terraform-gcp-config that referenced this pull request Nov 15, 2022
@afiune
fix: empty project_id in google_project data source (#75)
976ac9d 
A validation change hashicorp/terraform-provider-google#12846
was introduced in version `4.42.0` of the google provider. This
validation makes all our GCP modules to fail with:
```
│ Error: "" project_id must be 6 to 30 with lowercase letters, digits, hyphens and start with a letter. Trailing hyphens are prohibited.
│
│   with module.gcp_project_config.data.google_project.selected,
│   on .terraform/modules/gcp_project_config/main.tf line 96, in data "google_project" "selected":
│   96:   project_id = var.project_id
```

To solve this issue we are avoiding using the `google_project` data
source when we know the `project_id` that was provided by the user.

If the user does not provide a `project_id`, then we use the data
source to discover the project from the google provider.

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune added a commit to lacework/terraform-gcp-service-account that referenced this pull request Nov 15, 2022
@afiune
fix: empty project_id in google_project data source (#38)
a6a7c6c 
A validation change hashicorp/terraform-provider-google#12846
was introduced in version `4.42.0` of the google provider. This
validation makes all our GCP modules to fail with:
```
│ Error: "" project_id must be 6 to 30 with lowercase letters, digits, hyphens and start with a letter. Trailing hyphens are prohibited.
│
│   with module.gcp_service_account.data.google_project.selected,
│   on .terraform/modules/gcp_service_account/main.tf line 96, in data "google_project" "selected":
│   96:   project_id = var.project_id
```

To solve this issue we are avoiding using the `google_project` data
source when we know the `project_id` that was provided by the user.

If the user does not provide a `project_id`, then we use the data
source to discover the project from the google provider.

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune added a commit to lacework/terraform-gcp-gcr that referenced this pull request Nov 16, 2022
@afiune
fix: empty project_id in google_project data source
8c70210 
A validation change hashicorp/terraform-provider-google#12846
was introduced in version `4.42.0` of the google provider. This
validation makes all our GCP modules to fail with:
```
│ Error: "" project_id must be 6 to 30 with lowercase letters, digits, hyphens and start with a letter. Trailing hyphens are prohibited.
│
│   with module.gcp_project_gcr.data.google_project.selected,
│   on .terraform/modules/gcp_project_gcr/main.tf line 96, in data "google_project" "selected":
│   96:   project_id = var.project_id
```

To solve this issue we are avoiding using the `google_project` data
source when we know the `project_id` that was provided by the user.

If the user does not provide a `project_id`, then we use the data
source to discover the project from the google provider.

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
@afiune afiune mentioned this pull request Nov 16, 2022
Merged
afiune added a commit to lacework/terraform-gcp-gcr that referenced this pull request Nov 16, 2022
@afiune
fix: empty project_id in google_project data source
9ca1b9f 
A validation change hashicorp/terraform-provider-google#12846
was introduced in version `4.42.0` of the google provider. This
validation makes all our GCP modules to fail with:
```
│ Error: "" project_id must be 6 to 30 with lowercase letters, digits, hyphens and start with a letter. Trailing hyphens are prohibited.
│
│   with module.gcp_project_gcr.data.google_project.selected,
│   on .terraform/modules/gcp_project_gcr/main.tf line 96, in data "google_project" "selected":
│   96:   project_id = var.project_id
```

To solve this issue we are avoiding using the `google_project` data
source when we know the `project_id` that was provided by the user.

If the user does not provide a `project_id`, then we use the data
source to discover the project from the google provider.

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune added a commit to lacework/terraform-gcp-gcr that referenced this pull request Nov 16, 2022
@afiune
fix: empty project_id in google_project data source (#39)
7979c0d 
A validation change hashicorp/terraform-provider-google#12846
was introduced in version `4.42.0` of the google provider. This
validation makes all our GCP modules to fail with:
```
│ Error: "" project_id must be 6 to 30 with lowercase letters, digits, hyphens and start with a letter. Trailing hyphens are prohibited.
│
│   with module.gcp_project_gcr.data.google_project.selected,
│   on .terraform/modules/gcp_project_gcr/main.tf line 96, in data "google_project" "selected":
│   96:   project_id = var.project_id
```

To solve this issue we are avoiding using the `google_project` data
source when we know the `project_id` that was provided by the user.

If the user does not provide a `project_id`, then we use the data
source to discover the project from the google provider.

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune added a commit to lacework/terraform-gcp-gar that referenced this pull request Nov 16, 2022
@afiune
fix: empty project_id in google_project data source
96d90ef 
A validation change hashicorp/terraform-provider-google#12846
was introduced in version `4.42.0` of the google provider. This
validation makes all our GCP modules to fail with:
```
│ Error: "" project_id must be 6 to 30 with lowercase letters, digits, hyphens and start with a letter. Trailing hyphens are prohibited.
│
│   with module.gcp_project_gar.data.google_project.selected,
│   on .terraform/modules/gcp_project_gar/main.tf line 96, in data "google_project" "selected":
│   96:   project_id = var.project_id
```

To solve this issue we are avoiding using the `google_project` data
source when we know the `project_id` that was provided by the user.

If the user does not provide a `project_id`, then we use the data
source to discover the project from the google provider.

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
@afiune afiune mentioned this pull request Nov 16, 2022
Merged
afiune added a commit to lacework/terraform-gcp-gar that referenced this pull request Nov 16, 2022
@afiune
fix: empty project_id in google_project data source (#20)
387e1fe 
A validation change hashicorp/terraform-provider-google#12846
was introduced in version `4.42.0` of the google provider. This
validation makes all our GCP modules to fail with:
```
│ Error: "" project_id must be 6 to 30 with lowercase letters, digits, hyphens and start with a letter. Trailing hyphens are prohibited.
│
│   with module.gcp_project_gar.data.google_project.selected,
│   on .terraform/modules/gcp_project_gar/main.tf line 96, in data "google_project" "selected":
│   96:   project_id = var.project_id
```

To solve this issue we are avoiding using the `google_project` data
source when we know the `project_id` that was provided by the user.

If the user does not provide a `project_id`, then we use the data
source to discover the project from the google provider.

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data source google_project does not check for space at end of project_id
1 participant
@modular-magician