Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ed25519 keys #1185

Merged
merged 1 commit into from Oct 6, 2021
Merged

Allow ed25519 keys #1185

merged 1 commit into from Oct 6, 2021

Conversation

annerajb
Copy link
Contributor

@annerajb annerajb commented Oct 3, 2021 •
edited

Signed-off-by: Anner J. Bonilla abonilla@hoyosintegrity.com

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates hashicorp/vault#11780

Release note for CHANGELOG:

Allow Ed25519 on the PKI backend

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@annerajb
allow ed25519 keys
01096d4 
Signed-off-by: Anner J. Bonilla <abonilla@hoyosintegrity.com>
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 3, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@annerajb
Copy link
Contributor Author

annerajb commented Oct 5, 2021

FYI the feature got merged on vault few hours ago hashicorp/vault#11780

@annerajb
Copy link
Contributor Author

annerajb commented Oct 6, 2021

@vinay-gopalan @benashz

Who is the code owner if this that can add it to his queue for review?

@benashz benashz self-requested a review October 6, 2021 13:16
@benashz benashz merged commit c534482 into hashicorp:main Oct 6, 2021
benashz
benashz reviewed Oct 6, 2021
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fhilgers fhilgers mentioned this pull request Jan 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz left review comments

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@annerajb @hashicorp-cla @benashz