External changes report can fail with schema migrations and -target
#32900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where a provider has been upgraded, and there are external changes to resources outside of terraform, and -target is being used, and resources which are not targeted require a schema migration; the untargeted resources will not have been migrated and cannot be decoded for the external changes report. Since there is no way to decode the resources which have been excluded via -target, we can only skip over them when inspecting driftedResources. Return warnings for now to indicate that these resources could not be decoded to help indicate that users will need to eventually apply these changes.
jbardin
added
the
1.4-backport
alisdair
approved these changes
Mar 28, 2023
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a plan under the following conditions:
-targetflag is being usedThe un-targeted resources will not have been migrated to a new schema and cannot be decoded from the prior state for the external changes report.
Since there is no way to decode these resources which have been excluded via
-target, we can only skip over them when inspectingdriftedResources. Return warnings for now to indicate that these resources could not be decoded and users will need to eventually apply these changes.Fixes #31052