states/remote: Check for LockError error type #31263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to lock a remote state backend, failure due to an existing lock should return an instance of LockError. This allows the wrapping code to retry until the specified timeout, instead of immediately exiting. This commit adds a test for this in the TestRemoteLocks test helper, which is used in many of the remote state backend test suites.
alisdair
added
the
1.2-backport
jbardin
approved these changes
Jun 17, 2022
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to lock a remote state backend, failure due to an existing lock should return an instance of
LockError. This allows the wrapping code to retry until the specified timeout, instead of immediately exiting.This commit adds a test for this in the
TestRemoteLockstest helper, which is used in many of the remote state backend test suites.This would have caught the bug fixed by #31256, for example, and the http backend tests fail without the commit in that PR.