Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/Serialize DB Connection Attributes #12770

Merged
merged 20 commits into from Oct 11, 2021
Merged

UI/Serialize DB Connection Attributes #12770

merged 20 commits into from Oct 11, 2021

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Oct 8, 2021 •
edited

Previously, databases created in the UI were posting to the API with unrelated attributes if they had default values. The serializer filters the payload so only attrs relevant to the corresponding plugin_type POST to the API.

hashishaw
hashishaw reviewed Oct 8, 2021
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one thing to check before we merge

ui/app/serializers/database/connection.js Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault October 8, 2021 17:24 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 8, 2021 17:25 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 8, 2021 17:26 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 8, 2021 17:31 Inactive
@hellobontempo hellobontempo added this to the 1.9 milestone Oct 8, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 8, 2021 17:39 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 8, 2021 19:54 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 8, 2021 21:45 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 8, 2021 22:20 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 11, 2021 18:40 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 11, 2021 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 11, 2021 18:44 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 11, 2021 20:07 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 11, 2021 20:26 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 11, 2021 20:26 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 11, 2021 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 11, 2021 20:29 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 11, 2021 20:30 Inactive
hashishaw
hashishaw approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you

@hellobontempo hellobontempo merged commit 698d485 into main Oct 11, 2021
@hellobontempo hellobontempo deleted the ui/serialize-db-connection-attrs branch October 11, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

@hashishaw hashishaw hashishaw approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hellobontempo @Monkeychip @hashishaw