go-kms-wrapping update for Azure Key Vault's Managed HSM offering [backport 1.8.x] #12952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rachel Culpepper <84159930+rculpepper@users.noreply.github.com> Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
This introduces the "resource" config parameter and the AZURE_AD_RESOURCE environment variable from the updated go-kms-wrapping dependency. Co-authored-by: Rachel Culpepper <84159930+rculpepper@users.noreply.github.com> Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
requested review from
victorr,
sgmiller,
stevendpclark,
rculpepper and
divyapola5
Includes changes from @stevendpclark. Co-authored-by: Rachel Culpepper <84159930+rculpepper@users.noreply.github.com> Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
rculpepper
approved these changes
Oct 28, 2021
cipherboy
changed the title
cipherboy
changed the title
cipherboy
added a commit
to cipherboy/vault
that referenced
this pull request
Oct 28, 2021
In hashicorp#12952, merged as 94f2ef9, I incorrectly ran `go get -u ...` instead of `go get ...`, causing unnecessary updates to be pulled. Revert go.mod, go.sum to their earlier versions. Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
added a commit
that referenced
this pull request
Oct 28, 2021
* Revert to earlier go.mod, go.sum In #12952, merged as 94f2ef9, I incorrectly ran `go get -u ...` instead of `go get ...`, causing unnecessary updates to be pulled. Revert go.mod, go.sum to their earlier versions. Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com> * Update to hashicorp/go-kms-wrapping@v0.6.8 (fixed) Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12934 to 1.8.x
The recently released update of
go-kms-wrapping@v0.6.8includes support for Azure KeyVault's Managed HSM offering. While the non-HSM-backed KeyVault offering was initially supported, support for the Managed HSM offering was broken because required customization wasn't exposed from the underlying library (namely,environment.KeyVaultDNSSuffix).Respecting Azure SDK's
AZURE_AD_RESOURCEvariable (and mirroring it as aresourcefield in the KeyVault seal config struct) allows us to use this type of KeyVault.Update to
go.mod/go.sumwas created viago get -u github.com/hashicorp/go-kms-wrapping@v0.6.8followed by ago mod tidy.