KV bug fix on delete menu #13050
Merged
KV bug fix on delete menu #13050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnav28
approved these changes
Nov 4, 2021
Monkeychip
added a commit
that referenced
this pull request
Nov 4, 2021
Monkeychip
added a commit
that referenced
this pull request
Nov 4, 2021
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix. Jordan had correctly fixed the syntax but the parameter passed should have been true (my error). This was preventing the delete modal from showing.
Also, I made sure on tests that this was caught. Modals are tough because they are on the dom regardless of if they're open. I made this mistake and needed to check if the modal was active. I have corrected for this.
No changelog as this was a regression bug made recently by this PR.