Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use release artifacts #389

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Use release artifacts #389

merged 2 commits into from
Mar 22, 2024

Conversation

inverse
Copy link
Contributor

@inverse inverse commented Feb 20, 2024

Proposed Changes

To help unblock #381 due to the issues with arm7 and esbuild we could use the release artifacts instead.

  • Simplify nesting so that app is installed at /var/www/tasmoadmin
  • Remove additional cleaning code for non-app code in root of upstream repo

Related Issues

@inverse inverse mentioned this pull request Mar 15, 2024
Closed
@frenck frenck added the refactor Improvement of existing code, not introducing new features. label Mar 22, 2024
frenck
frenck reviewed Mar 22, 2024
View reviewed changes
tasmoadmin/Dockerfile Outdated Show resolved Hide resolved
frenck
frenck approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @inverse 👍

../Frenck

@frenck frenck merged commit 6fbb38a into hassio-addons:main Mar 22, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2024
@inverse inverse deleted the change-build branch April 22, 2024 12:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
refactor Improvement of existing code, not introducing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inverse @frenck