Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrades TasmoAdmin to v4.0.1 #381

Closed
wants to merge 5 commits into from

Conversation

inverse
Copy link
Contributor

@inverse inverse commented Feb 5, 2024

Proposed Changes

The major version bump is because of the frontend buildchain change which now has an npm build which takes care of everything.

Comes with the added bonus of not needing to include node_modules which brings the whole image down in size too!

tasmoadmin                                 before               baec78957941   About a minute ago   208MB
tasmoadmin                                 after                dec6ecd71462   3 minutes ago        182MB

Still seems quite big? I guess we could change the base image to be just vanilla alpine?

Tested by copying into my addon on my local instance and running there and all seems working from testing.

Related Issues

(Github link to related issues or pull requests)

tasmoadmin/Dockerfile Outdated Show resolved Hide resolved
@frenck
Copy link
Member

frenck commented Feb 5, 2024

Still seems quite big? I guess we could change the base image to be just vanilla alpine?

I think it is fairly OK?

CleanShot 2024-02-05 at 22 44 07@2x

The biggest chunk/layer is 116Mb, which is the official upstream node base images I've started using. (Mostly because I have too, as the shipped NodeJS by Alpine Linux will not build on armv7 due to a QEMU bug).

Looking at pure the add-on itself, it adds 31MB, of which about 6.9MB is for TasmoAdmin (including all assets and vendored libraries), and 24MB is basically the PHP and its dependencies.

What could be done, is building using the NodeJS base image in the first state, copy the www folder over from the second stage using the generic add-on base image.

This assumes the NodeJS runtime isn't used @ the normal add-on lifetime.

@inverse
Copy link
Contributor Author

inverse commented Feb 5, 2024

Thanks for explaining! Yeah it sounds like using the node image as the build environment and copying out could be a good solution.

@inverse inverse mentioned this pull request Feb 5, 2024
@frenck frenck added major This PR causes a major version bump in the version number. dependencies Upgrade or downgrade of project dependencies. labels Feb 9, 2024
@frenck
Copy link
Member

frenck commented Feb 9, 2024

I'm not fully understanding why this one is stuck on armv7

@inverse inverse changed the title ⬆️ Upgrades TasmoAdmin to v4.0.0 ⬆️ Upgrades TasmoAdmin to v4.0.1 Feb 20, 2024
@inverse
Copy link
Contributor Author

inverse commented Feb 20, 2024

Do you think it could be to do with now using esbuild?

evanw/esbuild#1556

@inverse
Copy link
Contributor Author

inverse commented Feb 20, 2024

I guess we can use the release artifacts as they include the assets already compiled

@inverse inverse mentioned this pull request Feb 20, 2024
@inverse
Copy link
Contributor Author

inverse commented Mar 15, 2024

Closing this in favour of #389 which should work as the frontend assets will be prebuilt.

Then I guess #383 could be tested and things should just work.

@inverse inverse closed this Mar 15, 2024
@inverse inverse deleted the bump-tasmoadmin-4.0.0 branch March 15, 2024 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies. major This PR causes a major version bump in the version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants