Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix spelling #2697

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

chore: fix spelling #2697

wants to merge 14 commits into from

Conversation

jsoref
Copy link

@jsoref jsoref commented Mar 8, 2024

Follow-up to #2073 / #2694

Fixes misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/heroku-cli/actions/runs/8197017565#summary-22418300558

The action will report that the changes in this PR would make it happy: https://github.com/jsoref/heroku-cli/actions/runs/8197017765#summary-22418301886

fwiw, it isn't terribly hard for me to rebase these PRs (although the CI is pretty expensive, so I haven't actually had time to see it finish).

jsoref added 14 commits March 7, 2024 18:45
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref jsoref requested a review from a team as a code owner March 8, 2024 00:55
it('has a missing missing output', function () {
it('has a missing output', function () {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this. It's possible the doubled word is intended...

@@ -816,7 +816,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/).

## [1.5.2] - 2017-04-27
### Changed
- Releax engines requirements in package.json.
- Relax engines requirements in package.json.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on things, it's possible that engine is correct (but my guess is that the current word is the right one)

const {formation, metaas_source, port, ...filteredRedis} = redis
const {formation, metas_source, port, ...filteredRedis} = redis
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant