Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix spelling #2697

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc
Expand Up @@ -46,7 +46,7 @@
"unicorn/prefer-ternary": "off" // TODO: fix issues and turn this back on
},

// Typescript settings
// TypeScript settings
"overrides": [
{
"files": ["**/*{.ts,tsx}"],
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/get-signed-from-stampy.yml
Expand Up @@ -8,7 +8,7 @@ jobs:
environment: Stampy
steps:
- uses: actions/checkout@v3
- name: download signed Windows installer from from Stampy
- name: download signed Windows installer from Stampy
env:
STAMPY_ARN: ${{ secrets.STAMPY_ARN }}
AWS_ACCESS_KEY_ID: ${{secrets.AWS_ACCESS_KEY_ID}}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/start-gh-release.yml
@@ -1,4 +1,4 @@
name: Watch for and start Github Release
name: Watch for and start GitHub Release

on:
pull_request_target:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/start-prerelease.yml
Expand Up @@ -48,7 +48,7 @@ jobs:
run: |
git config user.name "GitHub Actions Bot"
git config user.email "heroku-front-end+npm-releases@salesforce.com"
- name: publish tag to Github
- name: publish tag to GitHub
run: |
git tag "${{ env.TAG_NAME }}" -m "${{ env.TAG_NAME }}"
git push origin "${{ env.TAG_NAME }}"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tag-create-github-release.yml
@@ -1,4 +1,4 @@
name: Create Github Release & Tag version in Git
name: Create GitHub Release & Tag version in Git

on:
workflow_dispatch:
Expand Down Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Create & Push Git Tag
run: ./scripts/release/create-git-tag-and-push
shell: bash
- name: Release to Github
- name: Release to GitHub
# the script below will fail if run from a separate shell file
run: |
PACKAGE_VERSION=$(node -e "console.log(require('./lerna.json').version)")
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Expand Up @@ -6,7 +6,7 @@ This page lists the operational governance model of this project, as well as the

## Salesforce Sponsored

The intent and goal of open sourcing this project is to increase the contributor and user base. However, only Salesforce employees will be given `admin` rights and will be the final arbitrars of what contributions are accepted or not.
The intent and goal of open sourcing this project is to increase the contributor and user base. However, only Salesforce employees will be given `admin` rights and will be the final arbiters of what contributions are accepted or not.

# Issues, requests & ideas

Expand Down
2 changes: 1 addition & 1 deletion install-standalone.sh
Expand Up @@ -27,7 +27,7 @@
elif [ "\$(expr substr \$(uname -s) 1 5)" == "Linux" ]; then
OS=linux
else
echoerr "This installer is only supported on Linux and MacOS"
echoerr "This installer is only supported on Linux and macOS"
exit 1
fi

Expand Down
Expand Up @@ -67,7 +67,7 @@ describe('releases:rollback', function () {
.then(() => stdMocks.restore())
})

it('has a missing missing output', function () {
it('has a missing output', function () {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this. It's possible the doubled word is intended...

stdMocks.use()
process.stdout.columns = 80
let busl = nock('https://busl.test:443')
Expand Down
2 changes: 1 addition & 1 deletion packages/ci-v5/CHANGELOG.md
Expand Up @@ -816,7 +816,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/).

## [1.5.2] - 2017-04-27
### Changed
- Releax engines requirements in package.json.
- Relax engines requirements in package.json.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on things, it's possible that engine is correct (but my guess is that the current word is the right one)


## [1.5.1] - 2017-04-03
### Changed
Expand Down
2 changes: 1 addition & 1 deletion packages/ci-v5/test/unit/lib/disambiguate.unit.test.js
Expand Up @@ -25,7 +25,7 @@ describe('disambiguate', function () {
api.done()
})

it('erros when no pipelines are returned', async function () {
it('errors when no pipelines are returned', async function () {
const api = nock('https://api.heroku.com')
.get('/pipelines?eq[name]=notUUID')
.reply(200, [])
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/README.md
Expand Up @@ -98,7 +98,7 @@ Run one test, in this case plugin-certs-v5, with `yarn lerna run --scope @heroku

## Debugging

Using WebStorm (from Jetbrains / IntelliJ), you can run/debug an individual test case.
Using WebStorm (from JetBrains / IntelliJ), you can run/debug an individual test case.

- Create a new run/debug configuration
- Select the 'Mocha' type
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/commands/autocomplete/options.ts
Expand Up @@ -27,7 +27,7 @@ export default class Options extends AutocompleteBase {
// *args: refers to a Command's static args
// *argv: refers to the current execution's command line positional input
// Klass: (class) Command class
// completion: (object) object with data/methods to build/retrive options from cache
// completion: (object) object with data/methods to build/retrieve options from cache
// curPosition*: the current argv position the shell is trying to complete
// options: (string) white-space separated list of values for the shell to use for completion

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/lib/pipelines/kolkrabbi-api.ts
Expand Up @@ -62,7 +62,7 @@ export default class {
})
}

getPipelineGithub(pipeline: any) {
getPipelineGitHub(pipeline: any) {
return this.request(`/pipelines/${pipeline}/github`, {
method: 'GET',
})
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/test/unit/analytics.unit.test.ts
Expand Up @@ -214,7 +214,7 @@ describe('analytics (backboard has an error) with authorizationToken', () => {
user = netrc.machines[vars.apiHost]?.login || undefined
})

it('retreives user heroku API key', async () => {
it('retrieves user heroku API key', async () => {
const config = await Config.load()
config.platform = 'win32'
config.shell = 'fish'
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/test/unit/commands/ci/rerun.unit.test.ts
Expand Up @@ -26,7 +26,7 @@ describe('ci:rerun', () => {
}
const newTestRun = {
commit_branch: ghRepository.branch,
commit_message: 'lastest commit',
commit_message: 'latest commit',
commit_sha: ghRepository.ref,
id: 'b6512323-3a11-43ac-b4e4-9668b6a6b30c',
number: 11,
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/test/unit/commands/ci/run.unit.test.ts
Expand Up @@ -19,7 +19,7 @@ describe('ci:run', () => {
}
const newTestRun = {
commit_branch: ghRepository.branch,
commit_message: 'lastest commit',
commit_message: 'latest commit',
commit_sha: ghRepository.ref,
id: 'b6512323-3a11-43ac-b4e4-9668b6a6b30c',
number: 11,
Expand Down
Expand Up @@ -13,7 +13,7 @@ describe('pipelines:connect', () => {
.it('displays an error')
})

describe('with an account connected to Github', () => {
describe('with an account connected to GitHub', () => {
test
.nock('https://kolkrabbi.heroku.com', kolkrabbi => {
const kolkrabbiAccount = {
Expand Down
22 changes: 11 additions & 11 deletions packages/cli/test/unit/commands/pipelines/diff.unit.test.ts
Expand Up @@ -23,7 +23,7 @@ describe('pipelines:diff', function () {
stage: 'staging',
}

const targetGithubApp = {
const targetGitHubApp = {
repo: 'heroku/example-app',
}

Expand All @@ -40,7 +40,7 @@ describe('pipelines:diff', function () {
stage: 'production',
}

const downstreamApp1Github = {
const downstreamApp1GitHub = {
repo: 'heroku/example-app',
}

Expand All @@ -57,7 +57,7 @@ describe('pipelines:diff', function () {
stage: 'production',
}

const downstreamApp2Github = {
const downstreamApp2GitHub = {
repo: 'heroku/some-other-app',
}

Expand Down Expand Up @@ -121,9 +121,9 @@ describe('pipelines:diff', function () {
.nock(kolkrabbiApi, api => {
api
.get(`/apps/${downstreamApp1.id}/github`)
.reply(200, downstreamApp1Github)
.reply(200, downstreamApp1GitHub)
.get(`/apps/${downstreamApp2.id}/github`)
.reply(200, downstreamApp2Github)
.reply(200, downstreamApp2GitHub)
})
}

Expand All @@ -143,7 +143,7 @@ describe('pipelines:diff', function () {
.nock(kolkrabbiApi, api => {
api
.get(`/apps/${targetApp.id}/github`)
.reply(200, targetGithubApp)
.reply(200, targetGitHubApp)
})
.command(['pipelines:diff', `--app=${targetApp.name}`])
.catch(error => {
Expand All @@ -155,7 +155,7 @@ describe('pipelines:diff', function () {
.nock(kolkrabbiApi, api => {
api
.get(`/apps/${targetApp.id}/github`)
.reply(200, targetGithubApp)
.reply(200, targetGitHubApp)
})
.nock(apiUrl, api => {
api
Expand All @@ -180,11 +180,11 @@ describe('pipelines:diff', function () {
.nock(kolkrabbiApi, api => {
api
.get(`/apps/${targetApp.id}/github`)
.reply(200, targetGithubApp)
.reply(200, targetGitHubApp)
.get(`/apps/${downstreamApp1.id}/github`)
.reply(200, downstreamApp1Github)
.reply(200, downstreamApp1GitHub)
.get(`/apps/${downstreamApp2.id}/github`)
.reply(200, downstreamApp2Github)
.reply(200, downstreamApp2GitHub)
.get('/account/github/token')
.reply(200, {github: {token: 'github-token'}})
})
Expand Down Expand Up @@ -228,7 +228,7 @@ describe('pipelines:diff', function () {
})
.nock(githubApi, api => {
api
.get(`/repos/${targetGithubApp.repo}/compare/${hashes[1]}...${hashes[0]}`)
.get(`/repos/${targetGitHubApp.repo}/compare/${hashes[1]}...${hashes[0]}`)
.reply(404)
})
.command(['pipelines:diff', `--app=${targetApp.name}`])
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/tsconfig.json
@@ -1,6 +1,6 @@
{
"compilerOptions": {
"allowJs": true, // allowed to support run-foreman.js. Should be removed when that funcitonality is refactored.
"allowJs": true, // allowed to support run-foreman.js. Should be removed when that functionality is refactored.
"declaration": true,
"forceConsistentCasingInFileNames": true,
"importHelpers": true,
Expand Down
2 changes: 1 addition & 1 deletion packages/redis-v5/lib/shared.js
Expand Up @@ -105,7 +105,7 @@ module.exports = (context, heroku) => {

redis.app = db.addon.app
redis.config_vars = db.addon.config_vars
const {formation, metaas_source, port, ...filteredRedis} = redis
const {formation, metas_source, port, ...filteredRedis} = redis
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

redii.push(filteredRedis)
}

Expand Down
2 changes: 1 addition & 1 deletion scripts/postrelease/change_management
Expand Up @@ -10,7 +10,7 @@ if (!isStableRelease(GITHUB_REF_TYPE, GITHUB_REF_NAME)) {

const REQUEST_PROMISE = require('promise-request-retry')

// Set these in Github Actions in the heroku/cli project
// Set these in GitHub Actions in the heroku/cli project
//
const TPS_API_APP_ID = process.env.TPS_API_APP_ID
const TPS_API_RELEASE_ACTOR_EMAIL = process.env.TPS_API_RELEASE_ACTOR_EMAIL
Expand Down