Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-server): decode dynamic route params #271

Merged
merged 4 commits into from Apr 7, 2024

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Apr 7, 2024

Not sure where decoding should be applied. We should probably check with react router and tanstack.

Looking at tanstack, just running decodeURI for props.params seems enough, which is also what I did in the demo

todo

  • test

@hi-ogawa hi-ogawa marked this pull request as ready for review April 7, 2024 10:52
@hi-ogawa hi-ogawa merged commit 6f5b90c into main Apr 7, 2024
4 checks passed
@hi-ogawa hi-ogawa deleted the fix-dynamic-param-encoding branch April 7, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant