Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support highlighting GraphQL tagged template strings in JS/TS code #3713

Merged
merged 3 commits into from Feb 11, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.md
Expand Up @@ -4,7 +4,12 @@ New Grammars:

- added 3rd party Lang grammar to SUPPORTED_LANGUAGES [AdamRaichu][]

Grammars:

- Added support for highlighting GraphQL tagged template strings in JS/TS code [Ali Ukani][]

[AdamRaichu]: https://github.com/AdamRaichu
[Ali Ukani]: https://github.com/ali

## Version 11.8.0
joshgoebel marked this conversation as resolved.
Show resolved Hide resolved

Expand Down
15 changes: 15 additions & 0 deletions src/languages/javascript.js
Expand Up @@ -158,6 +158,19 @@ export default function(hljs) {
subLanguage: 'css'
}
};
const GRAPHQL_TEMPLATE = {
begin: 'gql`',
end: '',
starts: {
end: '`',
returnEnd: false,
contains: [
hljs.BACKSLASH_ESCAPE,
SUBST
],
subLanguage: 'graphql'
}
};
const TEMPLATE_STRING = {
className: 'string',
begin: '`',
Expand Down Expand Up @@ -219,6 +232,7 @@ export default function(hljs) {
hljs.QUOTE_STRING_MODE,
HTML_TEMPLATE,
CSS_TEMPLATE,
GRAPHQL_TEMPLATE,
TEMPLATE_STRING,
// Skip numbers when they are part of a variable name
{ match: /\$\d+/ },
Expand Down Expand Up @@ -453,6 +467,7 @@ export default function(hljs) {
hljs.QUOTE_STRING_MODE,
HTML_TEMPLATE,
CSS_TEMPLATE,
GRAPHQL_TEMPLATE,
TEMPLATE_STRING,
COMMENT,
// Skip numbers when they are part of a variable name
Expand Down
10 changes: 10 additions & 0 deletions test/markup/javascript/inline-languages.expect.txt
Expand Up @@ -20,5 +20,15 @@ css`<span class="language-css">
}
`</span>;

gql`<span class="language-graphql"><span class="hljs-keyword">query</span> <span class="hljs-punctuation">{</span> viewer <span class="hljs-punctuation">{</span> id <span class="hljs-punctuation">}</span> <span class="hljs-punctuation">}</span>`</span>;

gql`<span class="language-graphql">
<span class="hljs-keyword">type</span> Project <span class="hljs-punctuation">{</span>
<span class="hljs-symbol">name</span><span class="hljs-punctuation">:</span> String
<span class="hljs-symbol">tagline</span><span class="hljs-punctuation">:</span> String
<span class="hljs-symbol">contributors</span><span class="hljs-punctuation">:</span> <span class="hljs-punctuation">[</span>User<span class="hljs-punctuation">]</span>
<span class="hljs-punctuation">}</span>
`</span>;

<span class="hljs-comment">// Ensure that we&#x27;re back in JavaScript mode.</span>
<span class="hljs-keyword">var</span> foo = <span class="hljs-number">10</span>;
10 changes: 10 additions & 0 deletions test/markup/javascript/inline-languages.txt
Expand Up @@ -20,5 +20,15 @@ css`
}
`;

gql`query { viewer { id } }`;

gql`
type Project {
name: String
tagline: String
contributors: [User]
}
`;

// Ensure that we're back in JavaScript mode.
var foo = 10;
10 changes: 10 additions & 0 deletions test/markup/typescript/inline-languages.expect.txt
Expand Up @@ -20,5 +20,15 @@ css`<span class="language-css">
}
`</span>;

gql`<span class="language-graphql"><span class="hljs-keyword">query</span> <span class="hljs-punctuation">{</span> viewer <span class="hljs-punctuation">{</span> id <span class="hljs-punctuation">}</span> <span class="hljs-punctuation">}</span>`</span>;

gql`<span class="language-graphql">
<span class="hljs-keyword">type</span> Project <span class="hljs-punctuation">{</span>
<span class="hljs-symbol">name</span><span class="hljs-punctuation">:</span> String
<span class="hljs-symbol">tagline</span><span class="hljs-punctuation">:</span> String
<span class="hljs-symbol">contributors</span><span class="hljs-punctuation">:</span> <span class="hljs-punctuation">[</span>User<span class="hljs-punctuation">]</span>
<span class="hljs-punctuation">}</span>
`</span>;

<span class="hljs-comment">// Ensure that we&#x27;re back in TypeScript mode.</span>
<span class="hljs-keyword">var</span> foo = <span class="hljs-number">10</span>;
10 changes: 10 additions & 0 deletions test/markup/typescript/inline-languages.txt
Expand Up @@ -20,5 +20,15 @@ css`
}
`;

gql`query { viewer { id } }`;

gql`
type Project {
name: String
tagline: String
contributors: [User]
}
`;

// Ensure that we're back in TypeScript mode.
var foo = 10;