Upgrade Vite #506
Merged
Upgrade Vite #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilan-gold
commented
Sep 23, 2021
| import { getOmePixelSourceMeta, guessTileSize } from './lib/utils'; | ||
| import type Pool from './lib/Pool'; | ||
| import type { OmeTiffIndexer } from './lib/indexers'; |
There was a problem hiding this comment.
Got an error about the type not being found without this.
There was a problem hiding this comment.
Went back to try it again and get the actual text of the error and couldn't reproduce so reverted this change.
There was a problem hiding this comment.
Ah, ok I was looking in the wrong place. I get
Uncaught SyntaxError: import not found: OmeTiffIndexer
in the browser console.
|
@andreasg123 Could you try this out? |
|
@ilan-gold, thanks for doing this. As far as I can tell, this works for me. However, I would have to deal with the API name change so that I couldn't test it completely. There is one error in |
|
@andreasg123 Updated to resolve the import issue. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303 (I think)
Change List
~2.5.4Checklist