Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Vite #506

Merged
merged 4 commits into from
Sep 24, 2021
Merged

Upgrade Vite #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9dc3ff
Upgrade Vite
ilan-gold Sep 23, 2021
80d378a
Prettier.
ilan-gold Sep 23, 2021
e54bca1
Revert type import change.
ilan-gold Sep 23, 2021
16f844f
Fix indexer type import issue
ilan-gold Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- `channelIsOn` -> `channelsVisible`
- `loaderSelection` -> `selections`
- `MAX_SLIDERS_AND_CHANNELS` -> `MAX_CHANNELS`
- Upgrade `Vite` to `~2.5.4`

## 0.10.6

Expand Down
56 changes: 28 additions & 28 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"tape-catch": "^1.0.6",
"tape-run": "^8.0.0",
"typescript": "^4.1.3",
"vite": "^2.4.1"
"vite": "^2.5.4"
},
"dependencies": {
"@math.gl/culling": "^3.4.2",
Expand Down
7 changes: 2 additions & 5 deletions src/loaders/tiff/ome-tiff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,10 @@ import type { GeoTIFF } from 'geotiff';
import { fromString } from '../omexml';

import TiffPixelSource from './pixel-source';
import {
getOmeLegacyIndexer,
getOmeSubIFDIndexer,
OmeTiffIndexer
} from './lib/indexers';
import { getOmeLegacyIndexer, getOmeSubIFDIndexer } from './lib/indexers';
import { getOmePixelSourceMeta, guessTileSize } from './lib/utils';
import type Pool from './lib/Pool';
import type { OmeTiffIndexer } from './lib/indexers';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got an error about the type not being found without this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went back to try it again and get the actual text of the error and couldn't reproduce so reverted this change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok I was looking in the wrong place. I get

Uncaught SyntaxError: import not found: OmeTiffIndexer

in the browser console.


export interface OmeTiffSelection {
t: number;
Expand Down