-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration for APsystems EZ1 microinverter #114477
Add integration for APsystems EZ1 microinverter #114477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it why the bot says that I am changing 2 platforms. Shall I put the tests into a different PR? |
I don't understand the bot comment in this case either. |
@mawoka-myblock my best guess is that due to the HA documentation saying Limit to a single platform you are not allowed to change the platforms |
Regarding the platforms, you're right. Will remove the switch and number soon. I think I addressed most styles guidelines in the files here. They differ quite a bit from them in the Hass-repo. |
PR was reduced to single platform
Okay, sorry for the inconvenience, but I've created a new PR: #114531 |
Proposed change
The APsystems EZ1 microinverter has an open local HTTP api and I've created the integration over at https://github.com/SonnenladenGmbH/APsystems-EZ1-API-HomeAssistant but the people wanted to be integrated into HomeAssistant directly.
Type of change
Additional information
Some notes:
I couldn't run pre-commit on all files as that crashed my PC, since 16GB of ram weren't enough. This is also my first PR, so I tried my best. I also couldn't format with black, as it modified 200 other files as well.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: