Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration for APsystems EZ1 microinverter #114477

Closed

Conversation

mawoka-myblock
Copy link
Contributor

@mawoka-myblock mawoka-myblock commented Mar 30, 2024

Proposed change

The APsystems EZ1 microinverter has an open local HTTP api and I've created the integration over at https://github.com/SonnenladenGmbH/APsystems-EZ1-API-HomeAssistant but the people wanted to be integrated into HomeAssistant directly.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Some notes:
I couldn't run pre-commit on all files as that crashed my PC, since 16GB of ram weren't enough. This is also my first PR, so I tried my best. I also couldn't format with black, as it modified 200 other files as well.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mawoka-myblock
Copy link
Contributor Author

I don't get it why the bot says that I am changing 2 platforms. Shall I put the tests into a different PR?

@mawoka-myblock mawoka-myblock marked this pull request as ready for review March 30, 2024 13:06
@mawoka-myblock
Copy link
Contributor Author

Do you know whats wrong @patman15? You, @tcurdt, also mentioned your interest in this.

@tcurdt
Copy link

tcurdt commented Mar 30, 2024

I don't understand the bot comment in this case either.

@patman15
Copy link

Do you know whats wrong @patman15? You, @tcurdt, also mentioned your interest in this.

@mawoka-myblock my best guess is that due to the HA documentation saying Limit to a single platform you are not allowed to change the platforms switch, number, and sensor in a single PR.
Also note that there are the style guidelines that should be followed I guess. That were the changes I was talking about when saying I did more than just introducing the coordinator. 😉 Hope this helps, but I'm not an expert either, just interpreting what I read doing my code!

@mawoka-myblock
Copy link
Contributor Author

Regarding the platforms, you're right. Will remove the switch and number soon. I think I addressed most styles guidelines in the files here. They differ quite a bit from them in the Hass-repo.

@MartinHjelmare MartinHjelmare changed the title Added integration for APsystems EZ1 microinverter Add integration for APsystems EZ1 microinverter Mar 31, 2024
@farmio farmio dismissed home-assistant’s stale review March 31, 2024 08:07

PR was reduced to single platform

@mawoka-myblock
Copy link
Contributor Author

mawoka-myblock commented Mar 31, 2024

Okay, sorry for the inconvenience, but I've created a new PR: #114531

@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants