-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration docs for APsystems API #32096
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Thanks. I've commented the code out, as this will be added soon when I finish the other PRs in the core. |
ah, I was just going to ask about the comments. Please remove them from this PR, if they are related to changes from other core PRs. |
Okay, removed the comments |
Why did you close the PR? |
I didn't. You did in home-assistant/core#117782 You marked this PR to be closed by GitHub when that one would be merged by assign the ../Frenck |
Oh! I didn't know that and also didn't expect that, as I've just linked to a comment in this PR, not to the PR itself. |
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some more tiny nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you, @mawoka-myblock 👍
No problem, thank you for your nice feedback and all the commit suggestions below immediately! Really appreciate that! |
Proposed change
Adds integration docs
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.