Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert disabled_by to DeviceEntryDisabler on load #63944

Merged
merged 7 commits into from Jan 12, 2022
Merged

Convert disabled_by to DeviceEntryDisabler on load #63944

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
02adda8
Fix string comparison issues for device disabled_by attribute
agners Jan 11, 2022
58361c6
Fix string comparison issues with DeviceEntryType
agners Jan 11, 2022
7c8a661
Revert "Fix string comparison issues with DeviceEntryType"
agners Jan 12, 2022
f142b0b
Revert "Fix string comparison issues for device disabled_by attribute"
agners Jan 12, 2022
ae1fc53
Convert disabled_by to DeviceEntryDisabler on load
agners Jan 12, 2022
9b1862c
Add test
balloob Jan 12, 2022
70d06e9
Double assignment
balloob Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion homeassistant/helpers/device_registry.py
View file
Open in desktop
Expand Up @@ -553,7 +553,9 @@ async def async_load(self) -> None:
configuration_url=device["configuration_url"],
# type ignores (if tuple arg was cast): likely https://github.com/python/mypy/issues/8625
connections={tuple(conn) for conn in device["connections"]}, # type: ignore[misc]
disabled_by=device["disabled_by"],
disabled_by=DeviceEntryDisabler(device["disabled_by"])
if device["disabled_by"]
else None,
entry_type=DeviceEntryType(device["entry_type"])
if device["entry_type"]
else None,
Expand Down