Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace chrono with time crate #35

Merged
merged 4 commits into from Dec 13, 2022
Merged

Conversation

JohnTitor
Copy link
Contributor

@JohnTitor JohnTitor commented Jun 16, 2022

Fixes #32

Signed-off-by: Yuki Okushi jtitor@2k36.org

@JohnTitor JohnTitor marked this pull request as draft June 16, 2022 12:45
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@JohnTitor JohnTitor marked this pull request as ready for review June 21, 2022 13:21
@JohnTitor
Copy link
Contributor Author

time 0.3.10 is released, this is now ready to review :)

@JohnTitor JohnTitor changed the title [DNM] Replace chrono with time crate Replace chrono with time crate Jun 21, 2022
@norman784
Copy link

I would suggest to hide behind a feature flag time and leave chrono as default, otherwise it will be a huge breaking change.

@jbr
Copy link
Member

jbr commented Dec 13, 2022

I would suggest to hide behind a feature flag time and leave chrono as default, otherwise it will be a huge breaking change.

I think we can tolerate breaking changes here; it has been a while since the last release and frameworks will not be forced into upgrading until they are ready

@jbr jbr merged commit bbc072d into http-rs:main Dec 13, 2022
@JohnTitor JohnTitor deleted the replace-with-time branch December 13, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace chrono
3 participants