Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n-CN] Translated some files to implified Chinese #1915 #1916

Merged
merged 41 commits into from
Dec 20, 2023

Conversation

2404589803
Copy link
Contributor

@2404589803 2404589803 commented Dec 15, 2023

Related to #1915.

What is this PR about ?

I translated the following files to implified Chinese :

  • toctree.yml
  • index.md
  • installation.md
  • quick-start.md
  • git_vs_http.md
  • repository.md

What should you check ?

  • Grammar and orthograph
  • If my pull requests follows GitHub/open source contribution good practices (I am a beginner)

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @2404589803! Thanks for opening this PR! I am very enthusiastic of having this documentation translated to (simplified) Chinese! I have added a few technical comments about how to structure the PR but will not be able to review the content myself 🙂 Do you know people from the Chinese-speaking community that would be interested in reviewing your work?

README.md Outdated Show resolved Hide resolved
docs/source/cn/_redirects.yml Outdated Show resolved Hide resolved
docs/source/cn/安装.md Outdated Show resolved Hide resolved
@Wauplin
Copy link
Contributor

Wauplin commented Dec 18, 2023

Ping @adeenayakup and @xianbaoqian who will be interested in this! 🤗

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another comment I forgot: you should update the github workflow files so that cn docs are built as well. You should add cn in the languages parameter here and here.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link

@xianbaoqian xianbaoqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot to contributing the Chinese translation! Please check my comments.

docs/source/cn/_toctree.yml Outdated Show resolved Hide resolved
docs/source/cn/index(索引).md Outdated Show resolved Hide resolved
docs/source/cn/installation(安装).md Outdated Show resolved Hide resolved
Copy link

@adeenayakup adeenayakup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @2404589803. Your contribution is very much appreciated! 🤗 Here are some suggestions for the translation, don't hesitate to drop me a message if needed.

README_cn.md Outdated Show resolved Hide resolved
docs/source/cn/安装.md Outdated Show resolved Hide resolved
docs/source/cn/安装.md Outdated Show resolved Hide resolved
docs/source/cn/安装.md Outdated Show resolved Hide resolved
docs/source/cn/安装.md Outdated Show resolved Hide resolved
docs/source/cn/安装.md Outdated Show resolved Hide resolved
docs/source/cn/指南/储存库.md Outdated Show resolved Hide resolved
docs/source/cn/指南/储存库.md Outdated Show resolved Hide resolved
docs/source/cn/概念指南/git与HTTP相比较.md Outdated Show resolved Hide resolved
docs/source/cn/索引.md Outdated Show resolved Hide resolved
@Wauplin
Copy link
Contributor

Wauplin commented Dec 19, 2023

Thanks a lot for making all the requested changes so quickly @2404589803! 🙏 From a technical point of view, this PR is good and ready to be merged. From a content point of you (the translated parts), I let you iterate with @xianbaoqian and @adeenayakup 's feedback. Let me know once it's done!

@2404589803
Copy link
Contributor Author

OK, please wait until I finish the iteration before merging the branches, thank you very much !@Wauplin

@2404589803
Copy link
Contributor Author

At the same time, I am very grateful to everyone for your constructive suggestions on my work. Thank you.🤗 @Wauplin @xianbaoqian @adeenayakup

@2404589803
Copy link
Contributor Author

I have corrected all the above changes, and I also changed the link pointing inside the translated file (this link is used to jump between project files), because if there is no change, it will appear after merging the branch problem, although the review did not point this out.@Wauplin

README.md Outdated Show resolved Hide resolved
@xianbaoqian
Copy link

Great work! Thanks for the contribution. It looks much better. Added two minor comments, otherwise the content looks good to me. plz wait for @adeenayakup and @Wauplin 's comment as well.

image Btw you probably need to sync your working branch.

Copy link

@adeenayakup adeenayakup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! Thanks for your contribution @2404589803 , it is very helpful. ❤️

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d8476d) 82.28% compared to head (d952f4c) 81.76%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1916      +/-   ##
==========================================
- Coverage   82.28%   81.76%   -0.52%     
==========================================
  Files          65       65              
  Lines        8127     8127              
==========================================
- Hits         6687     6645      -42     
- Misses       1440     1482      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool! Love the quick feedback loop. Thanks again everyone for working on this piece. From my point of view it's good to go to let's merge it! 🚀

@Wauplin Wauplin merged commit 5100ee4 into huggingface:main Dec 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants