-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n-CN] Translated some files to implified Chinese #1915 #1916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @2404589803! Thanks for opening this PR! I am very enthusiastic of having this documentation translated to (simplified) Chinese! I have added a few technical comments about how to structure the PR but will not be able to review the content myself 🙂 Do you know people from the Chinese-speaking community that would be interested in reviewing your work?
Ping @adeenayakup and @xianbaoqian who will be interested in this! 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot to contributing the Chinese translation! Please check my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @2404589803. Your contribution is very much appreciated! 🤗 Here are some suggestions for the translation, don't hesitate to drop me a message if needed.
Thanks a lot for making all the requested changes so quickly @2404589803! 🙏 From a technical point of view, this PR is good and ready to be merged. From a content point of you (the translated parts), I let you iterate with @xianbaoqian and @adeenayakup 's feedback. Let me know once it's done! |
OK, please wait until I finish the iteration before merging the branches, thank you very much !@Wauplin |
At the same time, I am very grateful to everyone for your constructive suggestions on my work. Thank you.🤗 @Wauplin @xianbaoqian @adeenayakup |
I have corrected all the above changes, and I also changed the link pointing inside the translated file (this link is used to jump between project files), because if there is no change, it will appear after merging the branch problem, although the review did not point this out.@Wauplin |
Great work! Thanks for the contribution. It looks much better. Added two minor comments, otherwise the content looks good to me. plz wait for @adeenayakup and @Wauplin 's comment as well. Btw you probably need to sync your working branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go! Thanks for your contribution @2404589803 , it is very helpful. ❤️
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1916 +/- ##
==========================================
- Coverage 82.28% 81.76% -0.52%
==========================================
Files 65 65
Lines 8127 8127
==========================================
- Hits 6687 6645 -42
- Misses 1440 1482 +42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So cool! Love the quick feedback loop. Thanks again everyone for working on this piece. From my point of view it's good to go to let's merge it! 🚀
Related to #1915.
What is this PR about ?
I translated the following files to implified Chinese :
What should you check ?