Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished migration from setup.cfg to pyproject.toml #1971

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

jamesbraza
Copy link
Contributor

Most of the configs in setup.cfg were all unused/stale as of #1323 almost a year ago -- replaced with ruff. So this PR:

  • Migrates pytest config to pyproject.toml
  • Removes mostly unused setup.cfg
  • Removes old flake8: noqa comment in favor of ruff: noqa

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a27cce6) 82.22% compared to head (2d664c3) 82.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1971      +/-   ##
==========================================
+ Coverage   82.22%   82.49%   +0.27%     
==========================================
  Files          66       66              
  Lines        8147     8147              
==========================================
+ Hits         6699     6721      +22     
+ Misses       1448     1426      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for cleaning this up @jamesbraza! Changes looks good to me :)
We kept stale config for isort/flake for contributors to slowly moved out from them in favor of ruff. But should be good by now 😄

@Wauplin Wauplin merged commit f76dc44 into huggingface:main Jan 15, 2024
14 checks passed
@Wauplin Wauplin mentioned this pull request Jan 15, 2024
@jamesbraza jamesbraza deleted the removing-isort-stale-config branch January 15, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants