Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around issue with Node v14 and Puppeteer #2086

Merged
merged 1 commit into from Apr 27, 2020
Merged

Work around issue with Node v14 and Puppeteer #2086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/karma.config.js
View file
Open in desktop
Expand Up @@ -7,7 +7,15 @@ const envify = require('loose-envify/custom');
const glob = require('glob');

let chromeFlags = [];
process.env.CHROME_BIN = require('puppeteer').executablePath();

if (process.version.startsWith('v14.')) {
// See https://github.com/puppeteer/puppeteer/issues/5719
console.warn(
'Using system Chrome instead of Puppeteer due to issue with Node 14'
);
} else {
process.env.CHROME_BIN = require('puppeteer').executablePath();
}

// On Travis and in Docker, the tests run as root, so the sandbox must be
// disabled.
Expand Down