Work around issue with Node v14 and Puppeteer #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the system version of Chrome if the developer has Node v14 installed, to work around an upstream issue with Puppeteer (see code comment).
robertknight
force-pushed
the
node-v14-puppeteer-workaround
branch
from
9ba4775
to
74253d1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2086 +/- ##
=======================================
Coverage 97.02% 97.02%
=======================================
Files 185 185
Lines 6213 6213
Branches 1395 1395
=======================================
Hits 6028 6028
Misses 185 185 Continue to review full report at Codecov.
|
LMS007
approved these changes
Apr 27, 2020
robertknight
added a commit
to hypothesis/browser-extension
that referenced
this pull request
Apr 28, 2020
Apply the same fix as was used in the "client" repo in hypothesis/client#2086.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the system version of Chrome if the developer has Node v14
installed, to work around an upstream issue with Puppeteer (see code
comment).
The observed behavior under Node 14 is that running
make testfails with an error about Chrome not being captured (ie. Karma failed to launch Chrome)Further details: puppeteer/puppeteer#5719