Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] text-input-v1 support #1778

Merged
merged 9 commits into from Mar 14, 2023
Merged

[WIP] text-input-v1 support #1778

merged 9 commits into from Mar 14, 2023

Conversation

vaxerski
Copy link
Member

Adds support for tiv1

Doesn't seem to work yet due to chromium being weird...?

@fufexan for meson / nix (protocol added)

@vaxerski
Copy link
Member Author

hm, so far so good, but something's off. Chromium insta-crashes on any text input from IME lol

@vaxerski
Copy link
Member Author

Chromium doesn't crash most of the times now, oddly I can type entire sentences but the moment I try to type ! after a 乾杯 it dies.

@vaxerski
Copy link
Member Author

awright fixed crashes

@vaxerski
Copy link
Member Author

@dragove can you test this as the original reporter for the issue

@vaxerski vaxerski marked this pull request as ready for review March 13, 2023 21:47
@I-Want-ToBelieve
Copy link

I-Want-ToBelieve commented Mar 14, 2023

google-chrome-stable --enable-wayland-ime work well.
image

code --enable-wayland-ime It only shows the candidate word panel and cannot actually write into the input box.
And the positioning of the candidate word panel is always in the upper left corner. I am not sure if this is a problem with fcitx5, an electron problem or a hyprland problem.
image

I also tested other programs built with electron like marktext, yesplaymusic none of them have issues like vscode.

@q234rty
Copy link
Contributor

q234rty commented Mar 14, 2023

Tested this a bit on arch:

electron19 --enable-wayland-ime --ozone-platform=wayland https://github.com # doesn't work, same symptom as the comment above
electron20 --enable-wayland-ime --ozone-platform=wayland https://github.com # ditto
electron21 --enable-wayland-ime --ozone-platform=wayland https://github.com # works
electron22 --enable-wayland-ime --ozone-platform=wayland https://github.com # works

VSCode is currently using electron19, so I guess the electron/chromium behavior changed in recent versions of electron/chromium.

@q234rty
Copy link
Contributor

q234rty commented Mar 14, 2023

However, afaik all of the above works in weston and kwin, so there must be something that could be done by hyprland as well.

@I-Want-ToBelieve
Copy link

I-Want-ToBelieve commented Mar 14, 2023

https://github.com/electron/electron/releases/tag/v21.0.0-alpha.1

Added support for --ozone-platform-hint flag on Linux. electron/electron#34937 (Also in electron/electron#35015, electron/electron#35014)

code --enable-wayland-ime --ozone-platform-hint work well

@vaxerski
Copy link
Member Author

And the positioning of the candidate word panel is always in the upper left corner

Odd, as the client should send the cursor box. If it doesn't, then maybe hl doesn't send some event it expects?

Although if it works with electron >=21 I'd say it's a minor issue.

I'd rather push this (because it generally works) and work on that minor problem as time goes on. Seems stable to me, so no harm in doing that.

Feel free to open another issue for that.

Thanks for the feedback!

@vaxerski vaxerski merged commit 5dc1a5f into main Mar 14, 2023
11 checks passed
scorpion-26 pushed a commit to scorpion-26/Hyprland that referenced this pull request Apr 5, 2023
support zwp_text_input_v1

---------

Co-authored-by: Mihai Fufezan <fufexan@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants