Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Move sort() to ordered collections #1601

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BREAKING] Move sort() to ordered collections #1601

wants to merge 1 commit into from

Commits on Sep 19, 2018

  1. [BREAKING] Move sort() to ordered collections 

    Map.sort() returns an OrderedMap (same for Set and OrderedSet) which creates a circular dependency between them and makes it impossible to tree shake away the ordered variants.

WORK IN PROGRESS:
* Move the sort() and sortBy() dts and flow to Seq, List, Ordered*, Stack?
* Move generic definition on CollectionImpl to each usage
* Use method/function pattern?
    @leebyron
    leebyron committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    98ec724 View commit details
    Browse the repository at this point in the history