Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Move sort() to ordered collections #1601

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/Map.js
Expand Up @@ -21,7 +21,6 @@ import {
} from './TrieUtils';
import { hash } from './Hash';
import { Iterator, iteratorValue, iteratorDone } from './Iterator';
import { sortFactory } from './Operations';
import arrCopy from './utils/arrCopy';
import assertNotInfinite from './utils/assertNotInfinite';
import { setIn } from './methods/setIn';
Expand All @@ -37,8 +36,6 @@ import { asMutable } from './methods/asMutable';
import { asImmutable } from './methods/asImmutable';
import { wasAltered } from './methods/wasAltered';

import { OrderedMap } from './OrderedMap';

export class Map extends KeyedCollection {
// @pragma Construction

Expand Down Expand Up @@ -115,16 +112,6 @@ export class Map extends KeyedCollection {

// @pragma Composition

sort(comparator) {
// Late binding
return OrderedMap(sortFactory(this, comparator));
}

sortBy(mapper, comparator) {
// Late binding
return OrderedMap(sortFactory(this, comparator, mapper));
}

map(mapper, context) {
return this.withMutations(map => {
map.forEach((value, key) => {
Expand Down
11 changes: 11 additions & 0 deletions src/OrderedMap.js
Expand Up @@ -10,6 +10,7 @@ import { IS_ORDERED_SYMBOL } from './predicates/isOrdered';
import { isOrderedMap } from './predicates/isOrderedMap';
import { Map, emptyMap } from './Map';
import { emptyList } from './List';
import { reify, sortFactory } from './Operations';
import { DELETE, NOT_SET, SIZE } from './TrieUtils';
import assertNotInfinite from './utils/assertNotInfinite';

Expand Down Expand Up @@ -66,6 +67,16 @@ export class OrderedMap extends Map {
return updateOrderedMap(this, k, NOT_SET);
}

// @pragma Composition

sort(comparator) {
return reify(this, sortFactory(this, comparator));
}

sortBy(mapper, comparator) {
return reify(this, sortFactory(this, comparator, mapper));
}

wasAltered() {
return this._map.wasAltered() || this._list.wasAltered();
}
Expand Down
11 changes: 11 additions & 0 deletions src/OrderedSet.js
Expand Up @@ -10,6 +10,7 @@ import { IS_ORDERED_SYMBOL } from './predicates/isOrdered';
import { isOrderedSet } from './predicates/isOrderedSet';
import { IndexedCollectionPrototype } from './CollectionImpl';
import { Set } from './Set';
import { reify, sortFactory } from './Operations';
import { emptyOrderedMap } from './OrderedMap';
import assertNotInfinite from './utils/assertNotInfinite';

Expand All @@ -36,6 +37,16 @@ export class OrderedSet extends Set {
return this(KeyedCollection(value).keySeq());
}

// Composition

sort(comparator) {
return reify(this, sortFactory(this, comparator));
}

sortBy(mapper, comparator) {
return reify(this, sortFactory(this, comparator, mapper));
}

toString() {
return this.__toString('OrderedSet {', '}');
}
Expand Down
13 changes: 0 additions & 13 deletions src/Set.js
Expand Up @@ -10,14 +10,11 @@ import { isOrdered } from './predicates/isOrdered';
import { IS_SET_SYMBOL, isSet } from './predicates/isSet';
import { emptyMap } from './Map';
import { DELETE } from './TrieUtils';
import { sortFactory } from './Operations';
import assertNotInfinite from './utils/assertNotInfinite';
import { asImmutable } from './methods/asImmutable';
import { asMutable } from './methods/asMutable';
import { withMutations } from './methods/withMutations';

import { OrderedSet } from './OrderedSet';

export class Set extends SetCollection {
// @pragma Construction

Expand Down Expand Up @@ -136,16 +133,6 @@ export class Set extends SetCollection {
});
}

sort(comparator) {
// Late binding
return OrderedSet(sortFactory(this, comparator));
}

sortBy(mapper, comparator) {
// Late binding
return OrderedSet(sortFactory(this, comparator, mapper));
}

wasAltered() {
return this._map.wasAltered();
}
Expand Down