Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript typedefs to allow arrays of tuples #1727

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laughinghan
Copy link

When compiling TypeScript targeting ES5, if --downlevelIteration isn't
used, then arrays of tuples won't be considered assignable to iterables
of tuples, resulting in type errors when doing common things like
Map([['key', 'value']]):

microsoft/TypeScript#32761

--downlevelIteration hurts runtime performance of for..of loops on
arrays, but a type definition-only workaround is to explicitly include
arrays or arrays of tuples in parameter types or function overloads.

This apparently used to be masked by #1611, but became
a problem when #1626 was merged.

When compiling TypeScript targeting ES5, if --downlevelIteration isn't
used, then arrays of tuples won't be considered assignable to iterables
of tuples, resulting in type errors when doing common things like
Map([['key', 'value']]):

microsoft/TypeScript#32761

--downlevelIteration hurts runtime performance of for..of loops on
arrays, but a type definition-only workaround is to explicitly include
arrays or array sof tuples in parameter types or function overloads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant