Fix TypeScript typedefs to allow arrays of tuples #1727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling TypeScript targeting ES5, if
--downlevelIteration
isn'tused, then arrays of tuples won't be considered assignable to iterables
of tuples, resulting in type errors when doing common things like
Map([['key', 'value']])
:microsoft/TypeScript#32761
--downlevelIteration
hurts runtime performance offor..of
loops onarrays, but a type definition-only workaround is to explicitly include
arrays or arrays of tuples in parameter types or function overloads.
This apparently used to be masked by #1611, but became
a problem when #1626 was merged.