Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeScript typedefs to allow arrays of tuples #1727

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TypeScript typedefs to allow arrays of tuples #1727

wants to merge 1 commit into from

Commits on Aug 10, 2019

  1. Fix TypeScript typedefs to allow arrays of tuples 

    When compiling TypeScript targeting ES5, if --downlevelIteration isn't
used, then arrays of tuples won't be considered assignable to iterables
of tuples, resulting in type errors when doing common things like
Map([['key', 'value']]):

microsoft/TypeScript#32761

--downlevelIteration hurts runtime performance of for..of loops on
arrays, but a type definition-only workaround is to explicitly include
arrays or array sof tuples in parameter types or function overloads.
    @laughinghan
    laughinghan committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    4242715 View commit details
    Browse the repository at this point in the history