Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use yarn v3 with PnP linker #133

Merged
merged 9 commits into from Jul 5, 2022
Merged

fix: use yarn v3 with PnP linker #133

merged 9 commits into from Jul 5, 2022

Conversation

JounQin
Copy link
Collaborator

@JounQin JounQin commented Jul 4, 2022 •
edited

close #130

@JounQin JounQin self-assigned this Jul 4, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2022 •
edited

🦋 Changeset detected

Latest commit: f0b16bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-import-resolver-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 4, 2022 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022 •
edited

📊 Package size report   2%↑

File Before After
lib/index.js.map 7.2 kB -0.06%↓7.2 kB
package.json 3.9 kB 26%↑4.9 kB
README.md 7.8 kB -1.93%↓7.6 kB
Total (Includes all files) 44.9 kB 2%↑45.8 kB
Tarball size 11.9 kB 4%↑12.3 kB
Unchanged files
File Size
lib/index.cjs 8.3 kB
lib/index.d.ts 774 B
lib/index.es2015.mjs 7.3 kB
lib/index.js 8.3 kB
lib/worker.d.mts 11 B
lib/worker.mjs 206 B
lib/worker.mjs.map 327 B
LICENSE 757 B

🤖 This report was automatically generated by pkg-size-action

@JounQin JounQin force-pushed the fix/yarn_pnp branch 3 times, most recently from 4d3ef64 to 6b7a745 Compare July 4, 2022 15:03
@JounQin JounQin changed the title chore: use yarn v3 with node_modules nodeLinker chore: use yarn v3 with pnp Jul 4, 2022
@JounQin JounQin mentioned this pull request Jul 4, 2022
Closed
@JounQin JounQin mentioned this pull request Jul 5, 2022
Merged
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 5, 2022

This pull request introduces 16 alerts when merging c8bc8d1 into 6188681 - view on LGTM.com

new alerts:

  • 6 for Expression has no effect
  • 3 for Useless assignment to local variable
  • 3 for Unused variable, import, function or class
  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types
  • 1 for Unneeded defensive code
  • 1 for Incomplete string escaping or encoding

@JounQin JounQin changed the title chore: use yarn v3 with pnp fix: use yarn v3 with PnP linker Jul 5, 2022
@JounQin JounQin merged commit d944b26 into master Jul 5, 2022
@JounQin JounQin deleted the fix/yarn_pnp branch July 5, 2022 18:31
@github-actions github-actions bot mentioned this pull request Jul 5, 2022
Merged
@JounQin JounQin mentioned this pull request Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JounQin JounQin

Labels
bug dependencies internal
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to resolve modules when using yarn's PnP linker
1 participant
@JounQin