Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] order: add option pathGroupsExcludedImportTypes to allow ordering of external import types #1570

Merged
merged 1 commit into from Jan 2, 2020
Merged

[New] order: add option pathGroupsExcludedImportTypes to allow ordering of external import types #1570

merged 1 commit into from Jan 2, 2020

Conversation

Mairu
Copy link
Contributor

@Mairu Mairu commented Dec 14, 2019 •
edited by ljharb

… ordering of external import types

To fix the issue #1565 and have no BC break I added a new option to also allow sorting of external imports.

Fixes #1565.

@coveralls
Copy link

coveralls commented Dec 14, 2019 •
edited

Coverage Status

Coverage decreased (-0.1%) to 96.211% when pulling 16ae652 on Mairu:pathGroupsExcludedImportTypes into 982493d on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 96.322% when pulling 855748b on Mairu:pathGroupsExcludedImportTypes into 4e8960d on benmosher:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 96.322% when pulling 855748b on Mairu:pathGroupsExcludedImportTypes into 4e8960d on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 96.322% when pulling 855748b on Mairu:pathGroupsExcludedImportTypes into 4e8960d on benmosher:master.

@osdiab
Copy link

osdiab commented Jan 1, 2020

@benmosher @ljharb bump

@ljharb ljharb changed the title [New] order rule: add option pathGroupsExcludedImportTypes to allow… [New] order: add option pathGroupsExcludedImportTypes to allow ordering of external import types Jan 1, 2020
@ljharb ljharb force-pushed the pathGroupsExcludedImportTypes branch from c9d1aef to 16ae652 Compare January 2, 2020 06:22
@ljharb ljharb merged commit 16ae652 into import-js:master Jan 2, 2020
@ljharb ljharb mentioned this pull request Jan 2, 2020
Closed
@ljharb ljharb mentioned this pull request Aug 16, 2021
Open
@yola-0316 yola-0316 mentioned this pull request Sep 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-minor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import/order pathGroups not enforcing as expected
4 participants
@Mairu @coveralls @osdiab @ljharb