New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not remove attributes from class methods when visibility is mutated #1896

Merged

maks-rafalko merged 1 commit into master from bugfix/1895-attributes

Nov 8, 2023

Member

maks-rafalko commented Nov 8, 2023 •

edited

Previously, attributes were removed when e.g. public was mutated to protected.

Now, attributes are retained.

Bug is reproduced here: https://infection-php.dev/r/zokd

Fixes #1895


          Do not remove attributes from class methods when visibility is mutated

2d81db7

Previously, attributes were removed when e.g. `public` was mutated to `protected`.

Now, attributes are retained.

maks-rafalko added the Bugfix label

maks-rafalko enabled auto-merge (squash)

November 8, 2023 11:34

theofidry approved these changes

View reviewed changes

maks-rafalko merged commit 673ce76 into master

62 checks passed

maks-rafalko deleted the bugfix/1895-attributes branch

November 8, 2023 14:29

github-merge-queue bot pushed a commit to Lendable/clock that referenced this pull request


          Update Composer dev tooling dependencies (#553)

552636b

[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [infection/infection](https://togithub.com/infection/infection) |
`^0.27.7` -> `^0.27.8` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/infection%2finfection/0.27.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/infection%2finfection/0.27.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/infection%2finfection/0.27.7/0.27.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/infection%2finfection/0.27.7/0.27.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [php-cs-fixer/shim](https://togithub.com/PHP-CS-Fixer/shim) |
`^3.37.1` -> `^3.38.0` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/php-cs-fixer%2fshim/3.38.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/php-cs-fixer%2fshim/3.38.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/php-cs-fixer%2fshim/3.37.1/3.38.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/php-cs-fixer%2fshim/3.37.1/3.38.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>infection/infection (infection/infection)</summary>

###
[`v0.27.8`](https://togithub.com/infection/infection/releases/tag/0.27.8):
Do not remove attributes from class methods

[Compare
Source](https://togithub.com/infection/infection/compare/0.27.7...0.27.8)

**Fixed:**

- Do not remove attributes from class methods when visibility is mutated
by [@&#8203;maks-rafalko](https://togithub.com/maks-rafalko) in
[infection/infection#1896

**Full Changelog**:
infection/infection@0.27.7...0.27.8

</details>

<details>
<summary>PHP-CS-Fixer/shim (php-cs-fixer/shim)</summary>

###
[`v3.38.0`](https://togithub.com/PHP-CS-Fixer/shim/compare/v3.37.1...v3.38.0)

[Compare
Source](https://togithub.com/PHP-CS-Fixer/shim/compare/v3.37.1...v3.38.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Lendable/clock).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment