chore(eslint): upgrade eslint #15457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Pretty massive. Apologies. Mostly unneeded / improper use of |
drdelambre
previously requested changes
Oct 18, 2019
| } | ||
| parser: '@typescript-eslint/parser', | ||
| parserOptions: { | ||
| project: './tsconfig.test.json', |
| @@ -50,7 +50,9 @@ export class Signin extends PureComponent<Props, State> { | |||
|
|
|||
| if (this.hasMounted) { | |||
| this.setState({loading: RemoteDataState.Done}) | |||
| this.intervalID = setInterval(this.checkForLogin, FETCH_WAIT) | |||
| this.intervalID = setInterval(() => { | |||
| this.checkForLogin() | |||
| @@ -1,6 +1,7 @@ | |||
| // Libraries | |||
| import React, {SFC} from 'react' | |||
|
|
|||
| /* eslint-disable no-mixed-spaces-and-tabs */ | |||
There was a problem hiding this comment.
these should have a matching /* eslint-enable */ at the end of the file, in the name of compositional ease (changing include style, copy pasta, etc)
| @@ -1,6 +1,7 @@ | |||
| // Libraries | |||
| import React, {SFC} from 'react' | |||
|
|
|||
| /* eslint-disable no-mixed-spaces-and-tabs */ | |||
There was a problem hiding this comment.
needs a matching /* eslint-enable */
| @@ -1,6 +1,7 @@ | |||
| // Libraries | |||
| import React, {SFC} from 'react' | |||
|
|
|||
| /* eslint-disable no-mixed-spaces-and-tabs */ | |||
There was a problem hiding this comment.
needs a matching /* eslint-enable */
| @@ -13,6 +13,7 @@ const setup = (override?) => { | |||
| ...override, | |||
| } | |||
|
|
|||
| // eslint-disable-next-line | |||
There was a problem hiding this comment.
is there a specific rule we can add here?
| @@ -26,10 +26,10 @@ export function findIncludedsFromRelationships< | |||
| export function findIncludedFromRelationship< | |||
| T extends {id: string; type: TemplateType} | |||
| >( | |||
| includeds: {id: string; type: TemplateType}[], | |||
| included: {id: string; type: TemplateType}[], | |||
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
needs a matching /* eslint-enable */
| constructor() { | ||
| super(...arguments) | ||
| constructor(...args) { | ||
| super(...args) |
drdelambre
reviewed
Oct 18, 2019
drdelambre
dismissed
their stale review
watts promises to scope linting rules
121watts
force-pushed
the
chore/eslint-upgrade
branch
from
496ee92
to
c64896d
Compare
121watts
changed the title
drdelambre
approved these changes
Oct 18, 2019
| "webpack.tsconfig.json" | ||
| "webpack.tsconfig.json", | ||
| "webpack.*.ts", | ||
| "coverage" |
ebb-tide
approved these changes
Oct 18, 2019
| // but we cannot because of the default system buckets | ||
| // since cypress selectors are so fast, that sometimes a bucket | ||
| // that is deleted will be selected before it gets deleted | ||
| cy.reload() |
|
GOOD LUCK WITH YOUR MERGE CONFLICTS EVERYONE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded ESLINT and updated linter errors
typescript-eslint/typescript-eslint#389