-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint): upgrade eslint #15457
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
613e041
chore(eslint): upgraded eslint
asalem1 e9720c1
fix: typescript parser linting errors
121watts 321c6fc
chore: explicitly include files to be linted
121watts ade66b0
chore: first pass at recommended rules
121watts 3628633
fix: recommended rules
121watts a24b20b
fix: more recommended fixes
121watts cb8ad92
fix: last of recommended linter errors
121watts d4170a9
fix: creation of labels
121watts a967fc0
fix: typings for thunk
121watts 1b60845
fix: typing thunks
121watts 528df56
fix: thunk typings
121watts c64896d
chore: add eslint-enable
121watts bde7512
fix: oops
121watts 5ec64a0
fix: thunk typings
121watts 2d002fb
test: collectors reload page
121watts 75cfdcc
chore: exclude coverage from linting
121watts a136e41
fix: buckets delete test
121watts 2119fd6
chore: exclude from tsconfig
121watts File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,62 +1,69 @@ | ||
module.exports = { | ||
"parser": "@typescript-eslint/parser", | ||
"parserOptions": { | ||
"project": "./tsconfig.json", | ||
"tsconfigRootDir": __dirname, | ||
"ecmaFeatures": { | ||
"jsx": true | ||
} | ||
parser: '@typescript-eslint/parser', | ||
parserOptions: { | ||
project: './tsconfig.test.json', | ||
tsconfigRootDir: __dirname, | ||
ecmaFeatures: { | ||
jsx: true, | ||
}, | ||
}, | ||
"plugins": [ | ||
"@typescript-eslint", | ||
"react", | ||
"prettier" | ||
], | ||
"env": { | ||
"browser": true, | ||
"es6": true, | ||
"jest": true | ||
plugins: ['@typescript-eslint', 'react', 'prettier'], | ||
env: { | ||
browser: true, | ||
es6: true, | ||
jest: true, | ||
}, | ||
"extends": [ | ||
"eslint:recommended", | ||
"plugin:react/recommended", | ||
"plugin:@typescript-eslint/recommended", | ||
"plugin:prettier/recommended", | ||
"prettier/react", | ||
"prettier/@typescript-eslint" | ||
extends: [ | ||
'plugin:react/recommended', | ||
'plugin:prettier/recommended', | ||
'prettier/react', | ||
'prettier/@typescript-eslint', | ||
'eslint:recommended', | ||
'plugin:@typescript-eslint/eslint-recommended', | ||
'plugin:@typescript-eslint/recommended', | ||
'plugin:@typescript-eslint/recommended-requiring-type-checking', | ||
], | ||
"settings": { | ||
"react": { | ||
"version": "detect" | ||
} | ||
settings: { | ||
react: { | ||
version: 'detect', | ||
}, | ||
}, | ||
rules: { | ||
'no-console': ['error', {allow: ['warn', 'error']}], | ||
'no-empty': 'off', | ||
'getter-return': 'off', | ||
'no-extra-boolean-cast': 'off', | ||
'no-case-declarations': 'off', | ||
'no-useless-escape': 'off', | ||
'no-undef': 'off', | ||
'no-fallthrough': 'off', | ||
'@typescript-eslint/no-explicit-any': 'off', | ||
'@typescript-eslint/explicit-function-return-type': 'off', | ||
'@typescript-eslint/no-namespace': 'off', | ||
'@typescript-eslint/no-empty-interface': 'off', | ||
'@typescript-eslint/explicit-member-accessibility': 'off', | ||
'@typescript-eslint/no-use-before-define': 'off', | ||
'@typescript-eslint/no-object-literal-type-assertion': 'off', | ||
'@typescript-eslint/array-type': 'off', | ||
'@typescript-eslint/no-inferrable-types': 'off', | ||
'@typescript-eslint/no-var-requires': 'off', | ||
'@typescript-eslint/prefer-interface': 'off', | ||
'@typescript-eslint/camelcase': 'off', | ||
'@typescript-eslint/member-delimiter-style': 'off', | ||
'@typescript-eslint/prefer-regexp-exec': 'off', | ||
'@typescript-eslint/prefer-string-starts-ends-with': 'off', | ||
'@typescript-eslint/no-unused-vars': [ | ||
'error', | ||
{varsIgnorePattern: '^_', argsIgnorePattern: '^_'}, | ||
], | ||
'react/jsx-no-target-blank': 'off', | ||
'react/jsx-curly-brace-presence': [ | ||
'error', | ||
{props: 'never', children: 'never'}, | ||
], | ||
'react/display-name': 'off', | ||
'react/no-unescaped-entities': 'off', | ||
'react/prop-types': 'off', | ||
'react/no-find-dom-node': 'off', | ||
}, | ||
"rules": { | ||
"no-console": ["error", {"allow": ["warn", "error"]}], | ||
"no-empty": "off", | ||
"getter-return": "off", | ||
"no-extra-boolean-cast": "off", | ||
"no-case-declarations": "off", | ||
"no-useless-escape": "off", | ||
"no-undef": "off", | ||
"no-fallthrough": "off", | ||
"@typescript-eslint/no-explicit-any": "off", | ||
"@typescript-eslint/explicit-function-return-type": "off", | ||
"@typescript-eslint/no-namespace": "off", | ||
"@typescript-eslint/no-empty-interface": "off", | ||
"@typescript-eslint/explicit-member-accessibility": "off", | ||
"@typescript-eslint/no-use-before-define": "off", | ||
"@typescript-eslint/no-object-literal-type-assertion": "off", | ||
"@typescript-eslint/array-type": "off", | ||
"@typescript-eslint/no-inferrable-types": "off", | ||
"@typescript-eslint/no-var-requires": "off", | ||
"@typescript-eslint/prefer-interface": "off", | ||
"@typescript-eslint/camelcase": "off", | ||
"@typescript-eslint/no-unused-vars": ["error", {"varsIgnorePattern": "^_", "argsIgnorePattern": "^_"}], | ||
"react/jsx-no-target-blank": "off", | ||
"react/jsx-curly-brace-presence": ["error", {"props": "never", "children": "never" }], | ||
"react/display-name": "off", | ||
"react/no-unescaped-entities": "off", | ||
"react/prop-types": "off", | ||
"react/no-find-dom-node": "off" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,17 +54,19 @@ describe('Buckets', () => { | |
|
||
it('can delete a bucket', () => { | ||
const bucket1 = 'newbucket1' | ||
const bucket2 = 'newbucket2' | ||
cy.get<Organization>('@org').then(({id, name}: Organization) => { | ||
cy.createBucket(id, name, bucket1) | ||
cy.createBucket(id, name, bucket2) | ||
}) | ||
|
||
cy.getByTestID(`bucket--card--name ${bucket1}`).should('exist') | ||
|
||
cy.getByTestID(`context-delete-menu ${bucket1}`).click() | ||
cy.getByTestID(`context-delete-bucket ${bucket1}`).click() | ||
|
||
// normally we would assert for empty state here | ||
// but we cannot because of the default system buckets | ||
// since cypress selectors are so fast, that sometimes a bucket | ||
// that is deleted will be selected before it gets deleted | ||
cy.reload() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. got it. |
||
|
||
cy.getByTestID(`bucket--card--name ${bucket1}`).should('not.exist') | ||
}) | ||
}) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬 sorry