Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use domhandler node interface in htmlparser2 adapter #327

Merged
merged 8 commits into from Jan 6, 2022

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Nov 4, 2020

@TrySound
Copy link
Contributor Author

TrySound commented Nov 5, 2020

Tests are passing locally.

@fb55
Copy link
Collaborator

fb55 commented Nov 5, 2020

Looks great 👌

You might have to update the package-lock file for CI to pass. A npm install should do the job.

@TrySound
Copy link
Contributor Author

TrySound commented Nov 5, 2020

I guess I could but it's in gitignore for some reason

@TrySound
Copy link
Contributor Author

TrySound commented Nov 5, 2020

Btw do you use npm 7 or 6?

@fb55
Copy link
Collaborator

fb55 commented Nov 5, 2020

The lock file is has a version of 1, which is npm 6.

@TrySound
Copy link
Contributor Author

TrySound commented Nov 5, 2020

Caz adapter package does not have package-lock.json. And root one does not reflect workspaces. Yarn would work here. Probably npm 7 as well but I never tried it.

@TrySound
Copy link
Contributor Author

TrySound commented Nov 5, 2020

Ah, perhaps the problem is that travis uses npm 7 :)

@fb55
Copy link
Collaborator

fb55 commented Nov 5, 2020

True, very interesting. @inikulin can hopefully provide some background infos.

@TrySound
Copy link
Contributor Author

TrySound commented Nov 5, 2020

Travis changed their oss plan recently. A lot of builds are screwed up and take hours to finish. Perhaps they forces users to migrate to github actions and leave them alone.

@fb55
Copy link
Collaborator

fb55 commented Nov 25, 2020

Travis changed their oss plan recently

I found out yesterday that all that's needed is a migration from Travis' .org offering to their .com domain. Builds seem to be fast again once that's done.

@fb55
Copy link
Collaborator

fb55 commented Nov 25, 2020

@inikulin Any feedback on this change? I'd love to get out a new release of cheerio, and this is currently blocking.

@frank-dspeed
Copy link

@fb55 i am at present doing a large refactor i will implement that directly now into the new version

@fb55
Copy link
Collaborator

fb55 commented Mar 6, 2021

@frank-dspeed Very cool, let me know if you need any help!

@frank-dspeed frank-dspeed mentioned this pull request Mar 12, 2021
24 tasks
@inikulin
Copy link
Owner

inikulin commented Jun 9, 2021

Hi folks. Unfortunately I don't have enough time anymore to actively support the project. So, would love to see more co-maintainesr. @fb55 maybe you'd like to take over the project? Would appreciate if you spread the word and contact me via ivan@nikulin.engineering

@fb55
Copy link
Collaborator

fb55 commented Aug 2, 2021

@inikulin Thanks for your offer — I am happy to take over the project! I've sent you an email a few weeks back; my one ask would be to transfer the project to the @cheeriojs org (or its own org), to encourage others to contribute to the project.

Please let me know if there is anything I can do to make this easier for you!

@fb55 fb55 merged commit ccf296d into inikulin:master Jan 6, 2022
@fb55
Copy link
Collaborator

fb55 commented Jan 6, 2022

Thanks again for opening this @TrySound! Took a while to get this merged, but we are finally there.

jmbpwtw pushed a commit to jmbpwtw/parse5 that referenced this pull request Feb 16, 2023
Co-authored-by: Felix Böhm <188768+fb55@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants