Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make canary assets tag at the start of history to avoid tag calculation bugs #1803

Merged
merged 1 commit into from Feb 12, 2021
Merged

make canary assets tag at the start of history to avoid tag calculation bugs #1803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions plugins/upload-assets/__tests__/upload-assets-ci.test.ts
View file
Open in desktop
Expand Up @@ -43,6 +43,7 @@ describe("Upload Assets Plugin", () => {
prefixRelease: (v) => v,
git: {
options,
getFirstCommit: () => 'abc',
addToPrBody,
github: {
repos: { uploadReleaseAsset, createRelease },
Expand Down
3 changes: 3 additions & 0 deletions plugins/upload-assets/__tests__/upload-assets.test.ts
View file
Open in desktop
Expand Up @@ -115,6 +115,7 @@ describe("Upload Assets Plugin", () => {
logger: dummyLog(),
prefixRelease: (v) => v,
git: {
getFirstCommit: () => 'abc',
options,
github: {
repos: { uploadReleaseAsset, createRelease },
Expand Down Expand Up @@ -192,6 +193,7 @@ describe("Upload Assets Plugin", () => {
prefixRelease: (v) => v,
git: {
options,
getFirstCommit: () => 'abc',
github: {
repos: { uploadReleaseAsset, createRelease },
paginate: jest.fn().mockResolvedValue([]),
Expand Down Expand Up @@ -226,6 +228,7 @@ describe("Upload Assets Plugin", () => {
prefixRelease: (v) => v,
git: {
options,
getFirstCommit: () => 'abc',
github: {
repos: { uploadReleaseAsset, createRelease },
paginate: jest.fn().mockResolvedValue([]),
Expand Down
1 change: 1 addition & 0 deletions plugins/upload-assets/src/index.ts
View file
Open in desktop
Expand Up @@ -262,6 +262,7 @@ export default class UploadAssetsPlugin implements IPlugin {
name: "Canary Assets",
prerelease: true,
body: `This release contains preview assets of Pull Requests.`,
target_commitish: await auto.git?.getFirstCommit()
});

return canaryRelease.data;
Expand Down