Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrap canary identifier in quotes so terminal understands it's an argument to the --preid flag #1864

Merged
merged 2 commits into from Mar 11, 2021
Merged

wrap canary identifier in quotes so terminal understands it's an argument to the --preid flag #1864

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
069be34
wrap canary identifier in quotes so terminal understands it's an argu…
hipstersmoothie Mar 11, 2021
78d3f6c
fix lerna independent canary preid
hipstersmoothie Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/npm/src/index.ts
View file
Open in desktop
Expand Up @@ -1053,7 +1053,7 @@ export default class NPMPlugin implements IPlugin {
"--exact",
"--ignore-scripts",
"--preid",
canaryIdentifier,
canaryIdentifier.replace(/^-/, ''),
...verboseArgs,
]);

Expand All @@ -1078,7 +1078,7 @@ export default class NPMPlugin implements IPlugin {
"--no-git-reset", // so we can get the version that just published
"--no-git-tag-version", // no need to tag and commit,
"--exact", // do not add ^ to canary versions, this can result in `npm i` resolving the wrong canary version
...(isIndependent ? ["--preid", canaryIdentifier] : []),
...(isIndependent ? ["--preid", canaryIdentifier.replace(/^-/, '')] : []),
...verboseArgs,
]);

Expand Down