Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer npx over yarn for running lerna commands #1936

Merged
merged 2 commits into from Apr 9, 2021
Merged

Prefer npx over yarn for running lerna commands #1936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
165a837
Prefer npx over yarn for running lerna commands
zephraph Apr 7, 2021
8f3197c
Fix tests referencing yarn
zephraph Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/npm/__tests__/npm-next.test.ts
View file
Open in desktop
Expand Up @@ -513,7 +513,7 @@ describe("next", () => {
);
}

if (command === "yarn" && args[0] === "lerna" && args[1] === "changed") {
if (command === "npx" && args[0] === "lerna" && args[1] === "changed") {
return Promise.resolve("@foo/foo\n@foo/foo-bar");
}

Expand Down Expand Up @@ -596,7 +596,7 @@ describe("next", () => {
);
}

if (command === "yarn" && args[0] === "lerna" && args[1] === "changed") {
if (command === "npx" && args[0] === "lerna" && args[1] === "changed") {
return Promise.resolve("@foo/foo\n@foo/foo-bar");
}

Expand Down Expand Up @@ -666,7 +666,7 @@ describe("next", () => {
return Promise.resolve("@foo/foo@1.0.0-next.0");
}

if (command === "yarn" && args[0] === "lerna" && args[1] === "changed") {
if (command === "npx" && args[0] === "lerna" && args[1] === "changed") {
return Promise.resolve("@foo/foo (PRIVATE)");
}

Expand Down
6 changes: 3 additions & 3 deletions plugins/npm/src/index.ts
View file
Open in desktop
Expand Up @@ -379,7 +379,7 @@ const getIndependentNextReleases = async (
) => {
const packages = await getLernaPackages();
const [, changedPackagesResult = ""] = await on(
execPromise("yarn", ["lerna", "changed", "-a"])
execPromise("npx", ["lerna", "changed", "-a"])
);
const changedPackages = changedPackagesResult
.split("\n")
Expand Down Expand Up @@ -688,7 +688,7 @@ export default class NPMPlugin implements IPlugin {
// made, so no release will be made.
if (isIndependent) {
try {
await execPromise("yarn", ["lerna", "updated", "-a"]);
await execPromise("npx", ["lerna", "updated", "-a"]);
} catch (error) {
auto.logger.log.warn(
"Lerna detected no changes in project. Aborting release since nothing would be published."
Expand Down Expand Up @@ -836,7 +836,7 @@ export default class NPMPlugin implements IPlugin {
}

const [, changedPackagesResult = ""] = await on(
execPromise("yarn", ["lerna", "changed"])
execPromise("npx", ["lerna", "changed"])
);
const changedPackages = changedPackagesResult.split("\n");

Expand Down