Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #1997 #2010

Merged
merged 1 commit into from Jun 8, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 2 additions & 5 deletions plugins/npm/src/index.ts
Expand Up @@ -1005,9 +1005,6 @@ export default class NPMPlugin implements IPlugin {
}
};

canaryIdentifier = canaryIdentifier.replace(/^-/, "")


if (isMonorepo()) {
const isIndependent = getLernaJson().version === "independent";
auto.logger.verbose.info("Detected monorepo, using lerna");
Expand Down Expand Up @@ -1057,7 +1054,7 @@ export default class NPMPlugin implements IPlugin {
"--exact",
"--ignore-scripts",
"--preid",
canaryIdentifier,
canaryIdentifier.replace(/^-/, ""),
...verboseArgs,
]);

Expand All @@ -1083,7 +1080,7 @@ export default class NPMPlugin implements IPlugin {
"--no-git-tag-version", // no need to tag and commit,
"--exact", // do not add ^ to canary versions, this can result in `npm i` resolving the wrong canary version
...(isIndependent
? ["--preid", canaryIdentifier]
? ["--preid", canaryIdentifier.replace(/^-/, "")]
: []),
...verboseArgs,
]);
Expand Down