New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Protected branch plugin #2210
Conversation
a84dd37
to
80b635e
Compare
Codecov Report
@@ Coverage Diff @@
## main #2210 +/- ##
==========================================
+ Coverage 80.44% 80.60% +0.15%
==========================================
Files 67 69 +2
Lines 5519 5584 +65
Branches 1292 1300 +8
==========================================
+ Hits 4440 4501 +61
Misses 711 711
- Partials 368 372 +4
Continue to review full report at Codecov.
|
@hipstersmoothie anything that I can do to help merge this PR ? |
Hello 👋 |
{ | ||
name: this.name, | ||
// Include this plugin in a high priority stage in order to be mostly often before others plugins | ||
stage: -1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't even know this was a thing :O
|
||
// As reviewer, allowed in : `Restrict who can push to matching branches` | ||
auto.logger.log.info("Mark released pr as reviewed ✅ "); | ||
await gitOperator.approvePr(this.options.reviewerToken, prNumber, sha); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow that's clever. This is an impressive solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Amazing job (sorry on the slow merge). This is a wonderful contribution..
@jBouyoud Could you update the lock file? |
# Conflicts: # yarn.lock
🚀 PR was released in |
🎉 Thanks |
@hipstersmoothie I just realize that I've an improvement on my side that I not push here (do not rely on gh CLI and use auti Git class instead in order to remove a dependency and handle rate limits). I'll try to open a new PR for that. I see that you have implemented a cleanup (to delete the branch) ; You also have to think that the branch could not exists anymore for people using Github built-in branch deletion after merge. |
Pr? |
Please find the mentioned PR here |
What Changed
New plugin to handle protected branch that enforce administrator enforcements.
Why
Todo: N/A
Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major