Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve protected branch plugin #2317

Merged
merged 2 commits into from Feb 9, 2023

Conversation

jBouyoud
Copy link
Contributor

@jBouyoud jBouyoud commented Feb 8, 2023

What Changed

  • feat(protected-branch): rely on internal git object instead of external program
  • feat(protected-branch): silently ignore ref not found when deleting

Related to : #2210 (comment)

Why

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@jBouyoud jBouyoud marked this pull request as ready for review February 8, 2023 11:09
@jBouyoud jBouyoud mentioned this pull request Feb 8, 2023
6 tasks
@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Feb 8, 2023
@hipstersmoothie
Copy link
Collaborator

@jBouyoud Build failures

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #2317 (275b12c) into main (19febe4) will decrease coverage by 0.10%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #2317      +/-   ##
==========================================
- Coverage   80.67%   80.58%   -0.10%     
==========================================
  Files          69       69              
  Lines        5652     5654       +2     
  Branches     1327     1328       +1     
==========================================
- Hits         4560     4556       -4     
- Misses        714      717       +3     
- Partials      378      381       +3     
Impacted Files Coverage Δ
plugins/protected-branch/src/index.ts 77.55% <25.00%> (-2.89%) ⬇️
plugins/protected-branch/src/GitOperator.ts 100.00% <100.00%> (ø)
plugins/microsoft-teams/src/index.ts 81.81% <0.00%> (-3.64%) ⬇️
plugins/slack/src/index.ts 77.71% <0.00%> (-1.81%) ⬇️
packages/core/src/git.ts 87.05% <0.00%> (+0.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jBouyoud
Copy link
Contributor Author

jBouyoud commented Feb 9, 2023

Same as #2182 (comment)

@hipstersmoothie hipstersmoothie merged commit ae368cd into intuit:main Feb 9, 2023
@hipstersmoothie hipstersmoothie added patch Increment the patch version when merged and removed minor Increment the minor version when merged labels Feb 9, 2023
@github-actions github-actions bot added the minor Increment the minor version when merged label Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

🚀 PR was released in v10.41.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Feb 9, 2023
@jBouyoud jBouyoud deleted the improve-protected-branch branch February 10, 2023 08:21
@jBouyoud
Copy link
Contributor Author

Nice 🎉 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants