Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle EISDIR from lchown in node <10.6 #21

Merged
merged 3 commits into from Jul 3, 2019
Merged

Handle EISDIR from lchown in node <10.6 #21

merged 3 commits into from Jul 3, 2019

Commits on Jul 3, 2019

  1. Handle EISDIR from lchown in node <10.6 

    Fix #20
    @isaacs
    isaacs committed Jul 3, 2019
    Copy the full SHA
    b06e7ef View commit details
    Browse the repository at this point in the history

  2. Remove fundamentally broken symlink tests 

    These tests depend on being able to lchown a symbolic link to /bin/sh,
and rely on the assumption that /bin/sh is not owned by the current
user.

The first assumption will typically fail on Linux whenever the second
assumption is true!

Fixing the first, by linking to a local file instead, means that the
second is violated.

There is no way to save these tests, so they are being removed.
    @isaacs
    isaacs committed Jul 3, 2019
    Copy the full SHA
    32723fe View commit details
    Browse the repository at this point in the history

  3. .travis version update

    @isaacs
    isaacs committed Jul 3, 2019
    Copy the full SHA
    da434c3 View commit details
    Browse the repository at this point in the history