Support turning off node_modules default exclude via flag #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hershmire
changed the title
This was referenced Aug 24, 2018
|
Sorry for the delayed reply @hershmire, would you mind rebasing this? |
coreyfarrell
force-pushed
the
exclude-node_modules-flag
branch
from
f6e6bf6
to
3671356
Compare
coreyfarrell
approved these changes
Mar 4, 2019
There was a problem hiding this comment.
I've rebased. @JaKXz let me know if you have any objections otherwise I'll merge this soon. @hershmire sorry for the delay, thanks for being patient.
JaKXz
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step at resolving NYC's issue #898 I raised. The idea is to be able to turn off the default exclusion of
**/node_modules/**for users that need/want to support localnode_modules. As mentioned in that issue, thenegateExclude(i.e.!**/node_modules/**) doesn't work for cases when you still want your exclusion list to still exclude matches within your localnode_modulesdirectory.Related PRs for solving the above issue:
NOTE: Not sure if you also would want the
exportFunc.defaultExcludelist to take into account this option. For now, I'm not touching that so for this flag to work, at least oneexcludemust be present. Let me know if you would want this to also be included and I can make that edit. Thanks!