Fix no coverage with globally installed testers on Windows #104
Conversation
| @@ -147,6 +147,24 @@ function setup(argv, env) { | |||
| fs.writeFileSync(path.join(workingDir, cmdname), shim) | |||
| fs.chmodSync(path.join(workingDir, cmdname), '0755') | |||
| } | |||
| else if (cmdname === 'node') { | |||
| const nodePath = path.dirname(process.execPath) | |||
| const cmds = JSON.parse(env.NYC_CONFIG)._ | |||
There was a problem hiding this comment.
Perhaps instead of copying only the scripts from the process that nyc will use, it should copy all of them so any user of spaw-wrap and even chaining operations (one process calling the other) will work as expected.
There was a problem hiding this comment.
If running locally installed testers were a problem this could work, but it's not possible for us to copy every tester installed to the global path. The truth is that manipulation of scripts as done in spawn-wrap is problematic, I fear it's not possible to eliminate 100% of edge cases.
FYI an alternative I'm working on is istanbuljs/nyc#1169. The idea is that this will use environmental variables to wrap child processes. You can test this by running npm install -D git://github.com/coreyfarrell/nyc#set-node-options, then adding --set-node-options=true to your nyc command-line. Keep in mind this has not passed review, is subject to change and once merged that branch will be deleted. As mentioned in a comment on that PR a current issue is that clearing the environment will remove coverage from child processes. I'm working on a solution to that but the PR isn't updated yet.
There was a problem hiding this comment.
I'm a fan of the alternative that @coreyfarrell is working on, the copying of all the scripts seems a little bit heavy handed.
|
I appreciate this attempt but I believe |
This is a try on fixing the bug where nyc does not report coverage data when the test runners are installed globally on Windows. This fixes #1029 on nyc repo.
As I explained on the nyc issue, on Windows the modules "executables" are
*.cmdfiles that check if the node executable is under the same directory and if so they use it instead of the one in PATH.My solution is to copy those scripts (batch/shell/powershell) to the same temporary directory you guys already use for the node script and modify them to point to their correct module paths. Honestly I fear this solution is too dirty and not fail proof, but has worked fine with both AVA and mocha.
I have tested with
cmdandMSYS2/Mintty. I have not tested with local installations of the testers.CC: @bcoe