Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no coverage with globally installed testers on Windows #104

Closed
wants to merge 1 commit into from
Closed

Fix no coverage with globally installed testers on Windows #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions index.js
View file
Open in desktop
Expand Up @@ -147,6 +147,24 @@ function setup(argv, env) {
fs.writeFileSync(path.join(workingDir, cmdname), shim)
fs.chmodSync(path.join(workingDir, cmdname), '0755')
}
else if (cmdname === 'node') {
const nodePath = path.dirname(process.execPath)
const cmds = JSON.parse(env.NYC_CONFIG)._
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although nyc is a primary user of spawn-wrap it's not the only user. I tend to think it's not appropriate to look at process.env.NYC_CONFIG. CC @bcoe @isaacs any thoughts on this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps instead of copying only the scripts from the process that nyc will use, it should copy all of them so any user of spaw-wrap and even chaining operations (one process calling the other) will work as expected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If running locally installed testers were a problem this could work, but it's not possible for us to copy every tester installed to the global path. The truth is that manipulation of scripts as done in spawn-wrap is problematic, I fear it's not possible to eliminate 100% of edge cases.

FYI an alternative I'm working on is istanbuljs/nyc#1169. The idea is that this will use environmental variables to wrap child processes. You can test this by running npm install -D git://github.com/coreyfarrell/nyc#set-node-options, then adding --set-node-options=true to your nyc command-line. Keep in mind this has not passed review, is subject to change and once merged that branch will be deleted. As mentioned in a comment on that PR a current issue is that clearing the environment will remove coverage from child processes. I'm working on a solution to that but the PR isn't updated yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of the alternative that @coreyfarrell is working on, the copying of all the scripts seems a little bit heavy handed.

cmds.forEach((cmd) => {
const filepath = path.resolve(nodePath, cmd)
if (fs.existsSync(filepath + '.cmd')) {
const batch = fs.readFileSync(filepath + '.cmd', 'utf8')
const shell = fs.readFileSync(filepath, 'utf8')
const powershell = fs.readFileSync(filepath + '.ps1', 'utf8')
fs.writeFileSync(workingDir + '/' + cmd + '.cmd', batch.replace('"%_prog%" "%dp0%', '"%_prog%" "' + nodePath))
fs.chmodSync(workingDir + '/' + cmd + '.cmd', '0755')
fs.writeFileSync(workingDir + '/' + cmd, shell.replace('"$basedir/node" "$basedir', '"$basedir/node" "' + nodePath))
fs.chmodSync(workingDir + '/' + cmd, '0755')
fs.writeFileSync(workingDir + '/' + cmd + '.ps1', powershell.replace('node$exe" "$basedir', 'node$exe" "' + nodePath))
fs.chmodSync(workingDir + '/' + cmd + '.ps1', '0755')
}
})
}
fs.writeFileSync(path.join(workingDir, 'settings.json'), settings)

return workingDir
Expand Down