-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: migrate from source-map to TraceMap #186
Conversation
aeb6477
to
c4575c1
Compare
[trace-mapping](https://github.com/jridgewell/trace-mapping) is faster, smaller, and lighter than the `source-map` package, and doesn't require WASM, manual memory management, or async/await to use. Fixes istanbuljs#185.
c4575c1
to
c673bff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks!
this.sourceMap.destroy() | ||
this.sourceMap = undefined | ||
} | ||
this.sourceMap = undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed now? destroy
was added in #161, and I don't think it does much now? can keep the method around to avoid a breaking change I guess, but beyond that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I'll open a second PR to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @jridgewell, glad to see a drop in replacement 👍
Yay! ❤️ |
trace-mapping is faster, smaller, and lighter than the
source-map
package, and doesn't require WASM, manual memory management, or async/await to use.Fixes #185.