Support Net6 #50
Open
Support Net6 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/github/gitignore/blob/main/VisualStudio.gitignore - Update test to supported .net6 - Update nugets
- The lowest framework supported is 4.6.2 - Add CodePages to netstandard project to support net6 - net6 tests prove that this closes jaime-olivares#43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed all unsupported .net versions. By targeting only .netstandard2.0 this library can support any project that is Framework 4.6.2+, which is the lowest currently supported version. This has greatly simplified the codebase.
I upgraded the test project to .NET6, and moved the required
CodePagescalls to the constructor ofZipStorer. This proves that the change fixes the issue #43, which affects all modern users of this library due to changes in .NETCore.