Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(get.jenkins.io): remove long-lived SAS token and related outputs #654

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Apr 4, 2024

This PR removes mirrorbits file share long-lived SAS token and related outputs, replaced by the use of a storage key stored in jenkins-infra hieradata & charts-secrets.

Verification procedure after merging this PR: ensure update_center job still passes on trusted.ci.jenkins.io (file share used in sync.sh & sync-recent-releases.sh scripts)

Ref:

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll let you merge and monitor the pkg VM scripts when you are ready

@lemeurherve lemeurherve merged commit 1f0274f into jenkins-infra:main Apr 4, 2024
3 checks passed
@lemeurherve lemeurherve deleted the helpdesk3414-cleanup-get-jenkins-io branch April 4, 2024 10:20
@lemeurherve
Copy link
Member Author

The update center job passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants