Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CD permission for plugin-jetbrains-space #3801

Merged

Conversation

Kiryushin-Andrey
Copy link
Contributor

Link to GitHub repository

https://github.com/JetBrains/space-jenkins-plugin

When modifying release permission

List the GitHub usernames of the users who should have commit permissions below:

  • @username1
  • @username2

This is needed in order to cut releases of the plugin or component.

If you are modifying the release permission of your plugin or component, fill out the following checklist:

Release permission checklist (for submitters)

Edit tasklist title
Beta Give feedback Tasklist Release permission checklist (for submitters), more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to accounts.jenkins.io.
    Options
  2. All users added have logged in to Artifactory and Jira once.
    Options
  3. I have mentioned an existing team member of the plugin or component team to approve this request.
    Options

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Link to the PR enabling CD in your plugin

jenkinsci/jetbrains-space-plugin#7

CD checklist (for submitters)

Edit tasklist title
Beta Give feedback Tasklist CD checklist (for submitters), more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. I have provided a link to the pull request in my plugin, which enables CD according to the documentation.
    Options

Reviewer checklist

Edit tasklist title
Beta Give feedback Tasklist Reviewer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Check that the $pluginId Developers team has Admin permissions while granting the access.
    Options
  2. In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
    Options
  3. If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.
    Options

There are IRC Bot commands for it.

@Kiryushin-Andrey Kiryushin-Andrey requested a review from a team as a code owner March 5, 2024 11:38
@NotMyFault
Copy link
Member

NotMyFault commented Mar 5, 2024

Looks good so far, but be aware that cd will not work if your build doesn't pass all checks on ci.Jenkins.io

@NotMyFault NotMyFault merged commit ac36147 into jenkins-infra:master Mar 5, 2024
3 checks passed
@Kiryushin-Andrey
Copy link
Contributor Author

Kiryushin-Andrey commented Mar 5, 2024

Looks good so far, but be aware that cd will not work if your build doesn't pass all checks on ci.Jenkins.io

Ok, then I have a question about those checks :) They fail to fetch org.jetbrains:space-sdk-jvm dependency - Could not find artifact org.jetbrains:space-sdk-jvm:jar:2024.2-178074 in aws-proxy (https://repo.aws.jenkins.io/public/). But this dependency comes from https://maven.pkg.jetbrains.space/public/p/space/maven that is mentioned in the pom.xml file. Seems that the build on ci.jenkins.io for some reason ignores the repository referenced in the pom.xml and tried to fetch the dependency from this aws-proxy repo. So how can I either get the build to fetch the dependency from the right repo, or get this dependency published into the https://repo.aws.jenkins.io/public ?

I guess adding useArtifactCachingProxy: false to Jenkinsfile will help, but maybe I can use proxying for all the dependencies except this one?

@NotMyFault
Copy link
Member

NotMyFault commented Mar 5, 2024

I guess adding useArtifactCachingProxy: false to Jenkinsfile will help, but maybe I can use proxying for all the dependencies except this one?

I've exempted it in jenkins-infra/jenkins-infra#3314

@NotMyFault
Copy link
Member

For documentation purposes: jenkins-infra/helpdesk#3973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants